From 36d2b5926689cf0d95d0811cf14912379a785739 Mon Sep 17 00:00:00 2001 From: "we.kim" Date: Thu, 30 Jan 2020 09:15:36 +0900 Subject: [PATCH] Bugfix: Updated createTexture function in index*.js createTexture(gl, source, i) has a responsibility of creating GL Texture object with source data. creating texture object can be done even if the source is null, except calling texImage2D which is for uploading the buffer data to gpu memory. Fix solving this issue: https://github.com/codrops/RainEffect/issues/11 --- demo/js/index.js | 2 +- demo/js/index2.js | 2 +- demo/js/index3.js | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/demo/js/index.js b/demo/js/index.js index 1683fad..0dfb227 100644 --- a/demo/js/index.js +++ b/demo/js/index.js @@ -12621,7 +12621,7 @@ function createTexture(gl, source, i) { gl.texParameteri(gl.TEXTURE_2D, gl.TEXTURE_MIN_FILTER, gl.LINEAR); gl.texParameteri(gl.TEXTURE_2D, gl.TEXTURE_MAG_FILTER, gl.LINEAR); - updateTexture(gl, source); + if(source != null) updateTexture(gl, source); return texture; } diff --git a/demo/js/index2.js b/demo/js/index2.js index 63f8e75..3c82ec5 100644 --- a/demo/js/index2.js +++ b/demo/js/index2.js @@ -4814,7 +4814,7 @@ function createTexture(gl, source, i) { gl.texParameteri(gl.TEXTURE_2D, gl.TEXTURE_MIN_FILTER, gl.LINEAR); gl.texParameteri(gl.TEXTURE_2D, gl.TEXTURE_MAG_FILTER, gl.LINEAR); - updateTexture(gl, source); + if(source != null) updateTexture(gl, source); return texture; } diff --git a/demo/js/index3.js b/demo/js/index3.js index 0fbcc1c..ae89e9e 100644 --- a/demo/js/index3.js +++ b/demo/js/index3.js @@ -4832,7 +4832,7 @@ function createTexture(gl, source, i) { gl.texParameteri(gl.TEXTURE_2D, gl.TEXTURE_MIN_FILTER, gl.LINEAR); gl.texParameteri(gl.TEXTURE_2D, gl.TEXTURE_MAG_FILTER, gl.LINEAR); - updateTexture(gl, source); + if(source != null) updateTexture(gl, source); return texture; }