Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the theme support jupyter notebook #1

Closed
bobjason2020 opened this issue Oct 24, 2023 · 4 comments
Closed

Make the theme support jupyter notebook #1

bobjason2020 opened this issue Oct 24, 2023 · 4 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@bobjason2020
Copy link

When reading ipynb files using pycharm or dataspell software, the background of the page does not change color. I hope the notebook's code box and background color are different, which will help us to write code with jupyternotebook.
Or make a jupyter notebook style theme.
I would appreciate it if you could take my advice.

@furknyavuz furknyavuz self-assigned this Oct 24, 2023
@furknyavuz
Copy link
Contributor

Hi @bobjason2020,

Can you share a screenshot of the issue? It may help us to reproduce and fix it.

Thanks!

@furknyavuz furknyavuz added the bug Something isn't working label Oct 24, 2023
@furknyavuz furknyavuz added this to the 1.0.0 milestone Oct 24, 2023
@furknyavuz furknyavuz pinned this issue Oct 24, 2023
@bobjason2020
Copy link
Author

image
(For ipynb files)In the picture, When I use the Sakura Theme, the first part is pink, but the second part is white.I wish the second part would be pink as well, so that the dividing line between parts 2 and 3 would be clearer. The third part is the code block, and I think the different colors of the second part and the third part will help us improve the code editing experience.

@furknyavuz
Copy link
Contributor

Screenshot 2023-10-25 at 17 29 03

Hi @bobjason2020,

I would completely agree with you on your valid request. Changing the background color of the second section to pink makes so much sense. However, the code background for all other file types will also become pink, which could be an unpleasant experience for many users.

Until JetBrains adds a separate field for the second section of .ipynb file types, I wanted to share a solution with you:

If you are using .ipynb files heavily, feel free to update the "Default text" background color to the color you wish. Just do not forget that if you are coding in other file types they will have pink background too.

@furknyavuz
Copy link
Contributor

I'm closing the issue as answered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: done
Development

No branches or pull requests

3 participants