Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Orphaned availabilities #468

Closed
AuHau opened this issue Jun 30, 2023 · 3 comments
Closed

Orphaned availabilities #468

AuHau opened this issue Jun 30, 2023 · 3 comments
Assignees
Labels
bug Something isn't working Marketplace See https://miro.com/app/board/uXjVNZ03E-c=/ for details

Comments

@AuHau
Copy link
Member

AuHau commented Jun 30, 2023

I am not sure if it is a problem or not, but I have realised that Availabilities will be most probably never "used-up" as most probably there will be some capacity left in them (even very little) for which there won't be the proper Request's size (and other parameters) fit.

Is it a problem? WDYT? @markspanbroek @emizzle

@AuHau AuHau added bug Something isn't working marketplace labels Jun 30, 2023
@markspanbroek
Copy link
Member

The small leftovers should probably be merged with other compatible availabilities (e.g. with the one it originally split off from when it returns (#410))

@emizzle
Copy link
Contributor

emizzle commented Jul 4, 2023

This is a good point. I think we could have availabilities under a certain size (cli param-defined perhaps) try to merge with compatible exisiting availabilities (as @markspanbroek mentioned above) We would also need to consider attempting a merge when new availabilities are added, as there may still be availability dust floating around. As part of #455, there will be a signal triggered when availabilities are added, which could be utilised here.

(e.g. with the one it originally split off from when it returns (#410))

I'm not sure there is a "splitting" of availabilities. The current implementation simply reduces the availability's size as blocks are downloaded, then marks it unused after download. Once that availability gets to a certain size, we could then attempt to merge that availability with other availabilities that have looser (or equal) availability requirements.

@jessiebroke jessiebroke added the Marketplace See https://miro.com/app/board/uXjVNZ03E-c=/ for details label Dec 6, 2023
@AuHau AuHau self-assigned this Jan 15, 2024
@AuHau
Copy link
Member Author

AuHau commented Jan 15, 2024

This will be mainly solved by switching to "persistent availabilities" by default which is something I will be working on at #467

@AuHau AuHau closed this as completed May 9, 2024
@AuHau AuHau closed this as not planned Won't fix, can't repro, duplicate, stale May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Marketplace See https://miro.com/app/board/uXjVNZ03E-c=/ for details
Projects
None yet
Development

No branches or pull requests

4 participants