-
-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Last update 6.2 was "breaking" #448
Comments
In theory this shouldn't be breaking since Line 579 in 8d30a6f
That metric could definitely be improved though to prevent false positives. |
I have several users that use my ioBroker adapter that complain that they do not get data updates anymore as before. I now added also dp-refresh and let the users test. lets see what happens |
I got confirmation that now it is workign again for the users ... so in fact before the 6.2 it was enough to listen to the data event, not you need dp-refresh AND data ... |
BTW. Reasons are devices like the "LSC WLAN Video Doorbell" with this shema definition:
As you can see there is only IDs [103,104,106,108,109,110,111,115,117,134,136,150,151,154,160] ... so there is no id 1 in ... and for such devices the 6.2 was indeed breaking |
Hmm... any ideas what metric we could use instead? I went ahead and deprecated versions between 6.2.x and 7, then published 7; so hopefully that clears stuff up. |
Thank you for your clear statement to semantic versioning :-)) For the refresh in general I experimented a bit with a user and in the end really ended up in checking if the schema I know contains any of the fields from ones defined for refresh in library and if yes use refresh (still waiting for a user report to see if that worked) and else do that "get via set command and "null" as value directly what is the refresh fallback. Additionally i added a "device disonnected after refresh command before response" detection and never send a refresh then again ... but still waiting toget more user reports ... |
Ok, please do let me know what the results of those changes are once you have some feedback. :) |
Hi, Im sorry that I missed some devices. Please share your testing results and @codetheweb if you want I can help to improve it ;) |
Since the last update you need to use the new "dp-refresh" event and listen to it ... else you miss data.
So formally it was more a 7.0 then 6.3 :-(
The example in readme and other documentation should be updated
The text was updated successfully, but these errors were encountered: