feat: move disable rules to the end, remove deprecated rules

Author: coderwyd

src/configs/disables.ts

@@ -0,0 +1,55 @@
+import { GLOB_DTS, GLOB_SRC, GLOB_SRC_EXT } from '../constants/glob'
+import type { TypedFlatConfigItem } from '../types'
+
+export async function disables(): Promise<TypedFlatConfigItem[]> {
+  return [
+    {
+      files: [`scripts/${GLOB_SRC}`],
+      name: 'coderwyd/disables/scripts',
+      rules: {
+        'no-console': 'off',
+        'ts/explicit-function-return-type': 'off',
+        'unicorn/consistent-function-scoping': 'off',
+      },
+    },
+    {
+      files: [`cli/${GLOB_SRC}`, `cli.${GLOB_SRC_EXT}`],
+      name: 'coderwyd/disables/cli',
+      rules: {
+        'no-console': 'off',
+      },
+    },
+    {
+      files: ['**/bin/**/*', `**/bin.${GLOB_SRC_EXT}`],
+      name: 'coderwyd/disables/bin',
+      rules: {
+        'antfu/no-import-dist': 'off',
+        'antfu/no-import-node-modules-by-path': 'off',
+      },
+    },
+    {
+      files: [GLOB_DTS],
+      name: 'coderwyd/disables/dts',
+      rules: {
+        'eslint-comments/no-unlimited-disable': 'off',
+        'import/no-duplicates': 'off',
+        'no-restricted-syntax': 'off',
+        'unused-imports/no-unused-vars': 'off',
+      },
+    },
+    {
+      files: ['**/*.{test,spec}.([tj])s?(x)'],
+      name: 'coderwyd/disables/test',
+      rules: {
+        'no-unused-expressions': 'off',
+      },
+    },
+    {
+      files: ['**/*.js', '**/*.cjs'],
+      name: 'coderwyd/disables/cjs',
+      rules: {
+        'ts/no-require-imports': 'off',
+      },
+    },
+  ]
+}

src/configs/imports.ts

@@ -32,13 +32,5 @@ export function imports(
           : {}),
       },
     },
-    {
-      files: ['**/bin/**/*', `**/bin.${GLOB_SRC_EXT}`],
-      name: 'coderwyd/imports/disables/bin',
-      rules: {
-        'antfu/no-import-dist': 'off',
-        'antfu/no-import-node-modules-by-path': 'off',
-      },
-    },
   ]
 }

src/configs/index.ts

@@ -20,3 +20,4 @@ export * from './tailwindcss'
 export * from './command'
 export * from './regexp'
 export * from './jsx'
+export * from './disables'

src/configs/javascript.ts

@@ -243,19 +243,5 @@ export function javascript(
         ...overrides,
       },
     },
-    {
-      files: [`scripts/${GLOB_SRC}`, `cli.${GLOB_SRC_EXT}`],
-      name: 'coderwyd/javascript/disables/cli',
-      rules: {
-        'no-console': 'off',
-      },
-    },
-    {
-      files: ['**/*.{test,spec}.js?(x)'],
-      name: 'coderwyd/javascript/disables/test',
-      rules: {
-        'no-unused-expressions': 'off',
-      },
-    },
   ]
 }

src/configs/test.ts

@@ -54,6 +54,7 @@ export async function test(
         'test/prefer-lowercase-title': 'error',
 
         'ts/explicit-function-return-type': 'off',
+        'unicorn/consistent-function-scoping': 'off',
 
         ...overrides,
       },

src/configs/typescript.ts

@@ -121,7 +121,6 @@ export async function typescript(
           '@typescript-eslint': 'ts',
         }),
         'no-dupe-class-members': 'off',
-        'no-loss-of-precision': 'off',
         'no-redeclare': 'off',
         'no-use-before-define': 'off',
         'no-useless-constructor': 'off',
@@ -146,8 +145,6 @@ export async function typescript(
         'ts/no-extraneous-class': 'off',
         'ts/no-import-type-side-effects': 'error',
         'ts/no-invalid-void-type': 'off',
-        // this is deprecated
-        'ts/no-loss-of-precision': 'off',
         'ts/no-non-null-assertion': 'off',
         'ts/no-redeclare': 'error',
         'ts/no-require-imports': 'error',
@@ -176,30 +173,5 @@ export async function typescript(
           },
         ]
       : []),
-    {
-      files: [GLOB_DTS],
-      name: 'coderwyd/typescript/disables/dts',
-      rules: {
-        'eslint-comments/no-unlimited-disable': 'off',
-        'import/no-duplicates': 'off',
-        'no-restricted-syntax': 'off',
-        'unused-imports/no-unused-vars': 'off',
-      },
-    },
-    {
-      files: ['**/*.{test,spec}.ts?(x)'],
-      name: 'coderwyd/typescript/disables/test',
-      rules: {
-        'no-unused-expressions': 'off',
-      },
-    },
-    {
-      files: ['**/*.js', '**/*.cjs'],
-      name: 'coderwyd/typescript/disables/cjs',
-      rules: {
-        'ts/no-require-imports': 'off',
-        'ts/no-var-requires': 'off',
-      },
-    },
   ]
 }

src/configs/unicorn.ts

@@ -12,6 +12,7 @@ export function unicorn(): TypedFlatConfigItem[] {
         // 'unicorn/better-regex': 'error',
         'unicorn/catch-error-name': 'error',
         'unicorn/consistent-empty-array-spread': 'error',
+        'unicorn/consistent-function-scoping': ['error', { checkArrowFunctions: false }],
         'unicorn/custom-error-definition': 'error',
         'unicorn/error-message': 'error',
         // 'unicorn/explicit-length-check': 'error',