fixup! chore: enable tunnel binary verification

Author: deansheather

Installer/Installer.csproj

@@ -1,24 +1,24 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
-  <PropertyGroup>
-    <AssemblyName>Coder.Desktop.Installer</AssemblyName>
-    <RootNamespace>Coder.Desktop.Installer</RootNamespace>
-    <OutputType>Exe</OutputType>
-    <TargetFramework>net481</TargetFramework>
-    <LangVersion>13.0</LangVersion>
-  </PropertyGroup>
+    <PropertyGroup>
+        <AssemblyName>Coder.Desktop.Installer</AssemblyName>
+        <RootNamespace>Coder.Desktop.Installer</RootNamespace>
+        <OutputType>Exe</OutputType>
+        <TargetFramework>net481</TargetFramework>
+        <LangVersion>13.0</LangVersion>
+    </PropertyGroup>
 
-  <ItemGroup>
-    <None Remove="*.msi" />
-    <None Remove="*.exe" />
-    <None Remove="*.wxs" />
-    <None Remove="*.wixpdb" />
-    <None Remove="*.wixobj" />
-  </ItemGroup>
+    <ItemGroup>
+        <None Remove="*.msi" />
+        <None Remove="*.exe" />
+        <None Remove="*.wxs" />
+        <None Remove="*.wixpdb" />
+        <None Remove="*.wixobj" />
+    </ItemGroup>
 
-  <ItemGroup>
-    <PackageReference Include="WixSharp_wix4" Version="2.6.0" />
-    <PackageReference Include="WixSharp_wix4.bin" Version="2.6.0" />
-    <PackageReference Include="CommandLineParser" Version="2.9.1" />
-  </ItemGroup>
+    <ItemGroup>
+        <PackageReference Include="WixSharp_wix4" Version="2.6.0" />
+        <PackageReference Include="WixSharp_wix4.bin" Version="2.6.0" />
+        <PackageReference Include="CommandLineParser" Version="2.9.1" />
+    </ItemGroup>
 </Project>

Installer/Program.cs

@@ -256,7 +256,9 @@ private static int BuildMsiPackage(MsiOptions opts)
             new RegValue(RegistryHive, RegistryKey, "Manager:TunnelBinaryPath",
                 $"[INSTALLFOLDER]{opts.VpnDir}\\coder-vpn.exe"),
             new RegValue(RegistryHive, RegistryKey, "Manager:LogFileLocation",
-                @"[INSTALLFOLDER]coder-desktop-service.log"));
+                @"[INSTALLFOLDER]coder-desktop-service.log"),
+            new RegValue(RegistryHive, RegistryKey, "Manager:TunnelBinarySignatureSigner", "Coder Technologies Inc."),
+            new RegValue(RegistryHive, RegistryKey, "Manager:TunnelBinaryAllowVersionMismatch", "false"));
 
         // Note: most of this control panel info will not be visible as this
         // package is usually hidden in favor of the bootstrapper showing

Vpn.Service/Downloader.cs

@@ -96,6 +96,11 @@ public AssemblyVersionDownloadValidator(int expectedMajor, int expectedMinor, in
         if (_expectedBuild == -1 && _expectedRevision != -1)
             throw new ArgumentException("Build must be set if Revision is set", nameof(expectedRevision));
 
+        // Unfortunately the Version constructor throws an exception if the
+        // build or revision is -1. You need to use the specific constructor
+        // with the correct number of parameters.
+        //
+        // This is only for error rendering purposes anyways.
         if (_expectedBuild == -1)
             _expectedVersion = new Version(_expectedMajor, _expectedMinor);
         else if (_expectedRevision == -1)