Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat]: add e2e test for display-language patch #5367

Closed
jsjoeio opened this issue Jul 21, 2022 · 3 comments · Fixed by #5495
Closed

[Feat]: add e2e test for display-language patch #5367

jsjoeio opened this issue Jul 21, 2022 · 3 comments · Fixed by #5495
Assignees
@jsjoeio
Labels
enhancement Some improvement that isn't a feature testing Anything related to testing
Milestone
August 2022

Comments

@jsjoeio
Copy link
Contributor

jsjoeio commented Jul 21, 2022

What is your suggestion?

Add an e2e test for our display-language patch.

Why do you want this feature?

To prevent a regression like this which happened in 4.5.0

Are there any workarounds to get this functionality today?

Manually testing

Are you interested in submitting a PR for this?

Yes.
@jsjoeio jsjoeio added enhancement Some improvement that isn't a feature testing Anything related to testing labels Jul 21, 2022
@jsjoeio jsjoeio added this to the July 2022 milestone Jul 21, 2022
@jsjoeio
Copy link
Contributor Author

jsjoeio commented Aug 9, 2022

Upstream has made a fix that will make our patch irrelevant. See: microsoft/vscode#82595 (comment)

Therefore, we should hold off on this.

@jsjoeio jsjoeio self-assigned this Aug 9, 2022
@jsjoeio jsjoeio modified the milestones: v4.5.2, August 2022 Aug 15, 2022
@jsjoeio
Copy link
Contributor Author

jsjoeio commented Aug 17, 2022

my sense is to avoid an e2e test for now since hopefully upstream's implementation will be done soon
but i think if it is not done say a week before our next release we go ahead and add the e2e test so we can have it for the next release

@jsjoeio
Copy link
Contributor Author

jsjoeio commented Aug 23, 2022 •
edited
Loading

Thinking out loud how to write the e2e test:

  1. load code-server with language pack extension (i.e. Spanish) (similar to this)
  2. configure display language (select from command palette?)
  3. assert text "Explorar" or something in Spanish

@jsjoeio jsjoeio mentioned this issue Aug 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsjoeio jsjoeio

Labels
enhancement Some improvement that isn't a feature testing Anything related to testing
Projects
None yet
Milestone
August 2022
Development

Successfully merging a pull request may close this issue.

feat: add displayLang test coder/code-server
1 participant
@jsjoeio