Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor isNodeJSErrnoException function #4303

Closed
jsjoeio opened this issue Oct 4, 2021 · 1 comment
Closed

Refactor isNodeJSErrnoException function #4303

jsjoeio opened this issue Oct 4, 2021 · 1 comment
Labels
bug Something isn't working
Milestone

Comments

@jsjoeio
Copy link
Contributor

jsjoeio commented Oct 4, 2021

After a long discussion here, we came to the realization that there's a bug inside Jest which affects our function isNodeJSErrnoException.

$ node -e 'try { fs.readFileSync("/") } catch (error) { console.log(error instanceof Error) }'
true

References:

@jsjoeio jsjoeio added the bug Something isn't working label Oct 4, 2021
@jsjoeio jsjoeio added this to the On Deck milestone Oct 4, 2021
@stale
Copy link

stale bot commented Apr 2, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no activity occurs in the next 5 days.

@stale stale bot added the stale label Apr 2, 2022
@stale stale bot closed this as completed Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant