Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.408 doesn't work with --cert args #378

Closed
mentz opened this issue Mar 29, 2019 · 9 comments
Closed

1.408 doesn't work with --cert args #378

mentz opened this issue Mar 29, 2019 · 9 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@mentz
Copy link

mentz commented Mar 29, 2019

  • code-server version: 1.408-vsc1.32.0
  • OS Version: Ubuntu Server 18.04 LTS (VM on Hyper-V)

Description

Trying to run code-server with --cert and --cert-key arguments causes application to exit issuing error EEXIST: file already exists, mkdir '<cert-path>'.

Steps to Reproduce

  1. Acquire certificates for HTTPS operation
  2. Try to run code-server with certificates, e.g. ./code-server --cert fullchain.pem --cert-key privkey.pem

Error shown

Below is a complete example of the error I am getting when running code-server following above steps:

lucas@u1804-coder:~/code-server1.408-vsc1.32.0-linux-x64$ ./code-server --cert fullchain.pem --cert-key privkey.pem
ERROR { Error: EEXIST: file already exists, mkdir '/home/lucas/code-server1.408-vsc1.32.0-linux-x64/fullchain.pem'
  [stack]: 'Error: EEXIST: file already exists, mkdir \'/home/lucas/code-server1.408-vsc1.32.0-linux-x64/fullchain.pem\'',
  [message]: 'EEXIST: file already exists, mkdir \'/home/lucas/code-server1.408-vsc1.32.0-linux-x64/fullchain.pem\'',
  errno: -17,
  code: 'EEXIST',
  syscall: 'mkdir',
  path: '/home/lucas/code-server1.408-vsc1.32.0-linux-x64/fullchain.pem' }
free(): invalid pointer
Aborted (core dumped)

Previous versions

This error does not happen on previous code-server version 1.32.0-310.

@mentz mentz added the bug Something isn't working label Mar 29, 2019
@kylecarbs
Copy link
Member

Will fix. Thanks for the report!

@kylecarbs kylecarbs added this to the March 2019 milestone Mar 29, 2019
@mcp352
Copy link

mcp352 commented Mar 29, 2019

Exact same issue. Is there an easy workaround? Thanks for posting Mentz.

@mentz
Copy link
Author

mentz commented Mar 29, 2019

The "workaround" I'm using is reverting to version 1.32.0-310.

@code-asher code-asher self-assigned this Mar 29, 2019
@kmahyyg
Copy link

kmahyyg commented Mar 31, 2019

same issue as #351

@mentz
Copy link
Author

mentz commented Mar 31, 2019

Sorry, I didn't think it was a duplicate. Seeing that it's a different error I thought it would be better to open a new issue for this one.

@kirintwn
Copy link

kirintwn commented Apr 1, 2019

Got exact same error too, another workaround for now might be using reverse proxy like nginx to perform ssl transmission.

@code-asher
Copy link
Member

Did some testing and it looks like what fixed #351 also fixed this one (that fix hasn't been released yet though). The different arguments caused a different error message, but the root cause was the same.

@XiaolongMeng
Copy link

same error, waiting to be fixed

@kylecarbs
Copy link
Member

Fixed with the latest release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

7 participants