[SYCL][NFC] Remove idle flag (#1157)

Signed-off-by: Sergey Kanaev <[email protected]>

Author: s-kanaev

sycl/source/detail/kernel_program_cache.hpp

@@ -31,10 +31,9 @@ class KernelProgramCache {
     std::string Msg;
     pi_int32 Code;
 
-    /// Equals to true if the Msg and Code are initialized. This flag is added
-    /// due to the possibility of error code being equal to zero even in case 
-    /// if build is failed and cl::sycl::exception is thrown.
-    bool FilledIn;
+    bool isFilledIn() const {
+      return !Msg.empty();
+    }
   };
 
   /// Denotes pointer to some entity with its general state and build error.
@@ -46,7 +45,7 @@ class KernelProgramCache {
     std::atomic<int> State;
     BuildError Error;
 
-    BuildResult(T* P, int S) : Ptr{P}, State{S}, Error{"", 0, false} {}
+    BuildResult(T* P, int S) : Ptr{P}, State{S}, Error{"", 0} {}
   };
 
   using PiProgramT = std::remove_pointer<RT::PiProgram>::type;

sycl/source/detail/program_manager/program_manager.cpp

@@ -151,7 +151,7 @@ RetT *waitUntilBuilt(KernelProgramCache &Cache,
     return State == BS_Done || State == BS_Failed;
   });
 
-  if (BuildResult->Error.FilledIn) {
+  if (BuildResult->Error.isFilledIn()) {
     const KernelProgramCache::BuildError &Error = BuildResult->Error;
     throw ExceptionT(Error.Msg, Error.Code);
   }
@@ -237,7 +237,6 @@ RetT *getOrBuild(KernelProgramCache &KPCache, const KeyT &CacheKey,
   } catch (const exception &Ex) {
     BuildResult->Error.Msg = Ex.what();
     BuildResult->Error.Code = Ex.get_cl_code();
-    BuildResult->Error.FilledIn = true;
 
     BuildResult->State.store(BS_Failed);