Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable strict mode for transactions #50

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from
Open

Disable strict mode for transactions #50

wants to merge 12 commits into from

Conversation

michalsn
Copy link
Member

Description
This PR ensures that the queue uses the correct connection group defined in the config file and disables strict mode for transactions. Due to the nature of the queue worker (a long-running process), we don't want one failed transaction to affect others.

Needs #49

Fixes: #41

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@michalsn michalsn mentioned this pull request Sep 23, 2024
Open
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10989084030

Details

  • 14 of 14 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+2.9%) to 90.317%
Totals Coverage Status
Change from base Build 10938598555: 2.9%
Covered Lines: 513
Relevant Lines: 568
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Queue Not Logging Failed Tasks with Transactions
2 participants
@michalsn @coveralls