Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Handle non-array JSON in validation #8288

Merged
merged 2 commits into from
Dec 7, 2023
Merged

fix: Handle non-array JSON in validation #8288

merged 2 commits into from
Dec 7, 2023

Conversation

woodongwong
Copy link
Contributor

@woodongwong woodongwong commented Dec 4, 2023 •
edited by kenjis
Loading

Description
Continue #8176

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@woodongwong woodongwong mentioned this pull request Dec 4, 2023
Closed
5 tasks
@kenjis
Copy link
Member

kenjis commented Dec 6, 2023

Can you rebase to pass the Psalm check?

michalsn
michalsn approved these changes Dec 6, 2023
View reviewed changes
Copy link
Member

@michalsn michalsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Hopefully, the tests will pass.

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Dec 6, 2023
kenjis
kenjis approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@kenjis kenjis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kenjis kenjis merged commit b367f2f into codeigniter4:develop Dec 7, 2023
62 checks passed
@woodongwong woodongwong deleted the fix-Validation-withRequest branch December 7, 2023 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn approved these changes

@kenjis kenjis kenjis approved these changes

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@woodongwong @kenjis @michalsn