Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Factories::define() to explicitly override a class #7733

Merged
merged 27 commits into from
Jul 29, 2023
Merged

feat: add Factories::define() to explicitly override a class #7733

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
a8b528e
style: break long lines
kenjis Jul 9, 2023
85dd31b
refactor: extract isConfig()
kenjis Jul 24, 2023
79d3f35
docs: add doc comments
kenjis Jul 24, 2023
d7ed053
feat: [BC] add Factories::define() to override module classes
kenjis Jul 24, 2023
510c73f
chore: update psalm-baseline.xml for UndefinedClass
kenjis Jul 24, 2023
8629fdd
test: update failed test
kenjis Jul 24, 2023
3f23901
fix: when injecting Config mock with `Validation`, register the same …
kenjis Jul 24, 2023
86ca97b
style: remove empty line
kenjis Jul 24, 2023
74177ef
test: update failed test
kenjis Jul 24, 2023
88bbbcf
fix: preferApp is used with short classname only
kenjis Jul 24, 2023
da9ea30
docs: introduce term "class alias" for docs
kenjis Jul 25, 2023
fd4d88c
refactor: rename $basenames to $aliases
kenjis Jul 25, 2023
0fac66c
refactor: rename $name to $alias
kenjis Jul 25, 2023
d385e98
docs: improve doc comments
kenjis Jul 25, 2023
8880351
refactor: extract isNamespaced()
kenjis Jul 25, 2023
a1fa03f
docs: add @testTag
kenjis Jul 25, 2023
5b05bf9
refactor: use isNamespaced()
kenjis Jul 25, 2023
b482774
refactor: use isNamespaced()
kenjis Jul 25, 2023
a3c768a
test: add test
kenjis Jul 26, 2023
e3c223b
docs: update comments
kenjis Jul 26, 2023
244c5fb
refactor: extract getDefinedInstance()
kenjis Jul 26, 2023
340a930
fix: remove logic for preferApp for no namespaced Config classname
kenjis Jul 26, 2023
a13c53d
docs: update existing description
kenjis Jul 26, 2023
886fa87
docs: add about Factories::define()
kenjis Jul 26, 2023
9fdd3f1
docs: add changelog and upgrade guide
kenjis Jul 26, 2023
c48b523
docs: fix typo
kenjis Jul 26, 2023
89d6f37
docs: update existing descriptions
kenjis Jul 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions psalm-baseline.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="UTF-8"?>
<files psalm-version="5.12.0@f90118cdeacd0088e7215e64c0c99ceca819e176">
<files psalm-version="5.13.1@086b94371304750d1c673315321a55d15fc59015">
<file src="system/Cache/Handlers/MemcachedHandler.php">
<UndefinedClass>
<code>Memcache</code>
Expand Down Expand Up @@ -104,7 +104,9 @@
</file>
<file src="tests/system/Config/FactoriesTest.php">
<UndefinedClass>
<code><![CDATA['SomeWidget']]></code>
<code><![CDATA['App\Models\UserModel']]></code>
<code><![CDATA['App\Models\UserModel']]></code>
<code><![CDATA['Config\TestRegistrar']]></code>
</UndefinedClass>
</file>
<file src="tests/system/Database/BaseConnectionTest.php">
Expand Down
Loading