fix: parsing equal key name replace for parser

Author: CosDiabos

system/View/Parser.php

@@ -256,29 +256,28 @@ protected function parse(string $template, array $data = [], ?array $options = n
 
         // Parse stack for each parse type (Single and Pairs)
         $replaceSingleStack = [];
-        $replacePairsStack = [];
+        $replacePairsStack  = [];
 
         // loop over the data variables, saving regex and data
         // for later replacement.
         foreach ($data as $key => $val) {
             $escape = true;
 
             if (is_array($val)) {
-                $escape  = false;
-                array_push($replacePairsStack, ['replace' => $this->parsePair($key, $val, $template), 'escape' => $escape]);
+                $escape              = false;
+                $replacePairsStack[] = ['replace' => $this->parsePair($key, $val, $template), 'escape' => $escape];
             } else {
-                array_push($replaceSingleStack, ['replace' => $this->parseSingle($key, (string) $val), 'escape' => $escape]);
+                $replaceSingleStack[] = ['replace' => $this->parseSingle($key, (string) $val), 'escape' => $escape];
             }
         }
 
         // Merge both stacks, pairs first + single stacks
         // This allows for nested data with the same key to be replaced properly
         $replace = array_merge($replacePairsStack, $replaceSingleStack);
 
-        // Loop over each replace array item which 
+        // Loop over each replace array item which
         // holds all the data to be replaced
         foreach ($replace as $replaceItem) {
-
             // Loop over the actual data to be replaced
             foreach ($replaceItem['replace'] as $pattern => $content) {
                 $template = $this->replaceSingle($pattern, $content, $template, $replaceItem['escape']);

tests/system/View/ParserTest.php

@@ -1061,4 +1061,44 @@ public function testChangeConditionalDelimitersWorkWithJavaScriptCode(): void
             EOL;
         $this->assertSame($expected, $this->parser->renderString($template));
     }
+
+    /**
+     * @see https://github.com/codeigniter4/CodeIgniter4/issues/9245
+     */
+    public function testParseSameArrayKeyName(): void
+    {
+        $data = [
+            'type'   => 'Super Powers',
+            'powers' => [
+                [
+                    'type' => 'invisibility',
+                ],
+            ],
+        ];
+
+        $template = '{type} like {powers}{type}{/powers}';
+
+        $this->parser->setData($data);
+        $this->assertSame('Super Powers like invisibility', $this->parser->renderString($template));
+    }
+
+    public function testParseSameArrayKeyNameNested(): void
+    {
+        $data = [
+            'title'   => 'My title',
+            'similar' => [
+                ['items' => [
+                    [
+                        'title' => 'My similar title',
+                    ],
+                ],
+                ],
+            ],
+        ];
+
+        $template = '{title} with similar item {similar}{items}{title}{/items}{/similar}';
+
+        $this->parser->setData($data);
+        $this->assertSame('My title with similar item My similar title', $this->parser->renderString($template));
+    }
 }