Skip to content

Commit 56775d0

Browse files
committed
docs: updated to suggested changes
Also add an ignore in phpstan to ignore missing foundRows in BaseConnection
1 parent 698f643 commit 56775d0

File tree

4 files changed

+8
-3
lines changed

4 files changed

+8
-3
lines changed

phpstan-baseline.php

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13459,6 +13459,12 @@
1345913459
'count' => 2,
1346013460
'path' => __DIR__ . '/tests/system/Database/Live/MySQLi/NumberNativeTest.php',
1346113461
];
13462+
$ignoreErrors[] = [
13463+
// identifier: property.notFound
13464+
'message' => '#^Access to an undefined property CodeIgniter\\\\Database\\\\BaseConnection\\:\\:\\$foundRows\\.$#',
13465+
'count' => 2,
13466+
'path' => __DIR__ . '/tests/system/Database/Live/MySQLi/FoundRowsTest.php',
13467+
];
1346213468
$ignoreErrors[] = [
1346313469
// identifier: missingType.property
1346413470
'message' => '#^Property CodeIgniter\\\\Database\\\\Live\\\\MySQLi\\\\NumberNativeTest\\:\\:\\$tests has no type specified\\.$#',

system/Database/BaseConnection.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@
3535
* @property-read string $DSN
3636
* @property-read array|bool $encrypt
3737
* @property-read array $failover
38-
* @property-read bool $foundRows
3938
* @property-read string $hostname
4039
* @property-read Query $lastQuery
4140
* @property-read string $password

system/Database/MySQLi/Connection.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ class Connection extends BaseConnection
8484
/**
8585
* Use MYSQLI_CLIENT_FOUND_ROWS
8686
*
87-
* Whether affected_rows should return number of rows found,
87+
* Whether affectedRows() should return number of rows found,
8888
* or number of rows changed, after an UPDATE query.
8989
*
9090
* @var bool

user_guide_src/source/changelogs/v4.6.0.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ Forge
121121
Others
122122
------
123123

124-
- Added a new configuration `foundRows` for MySQLi to use `MYSQLI_CLIENT_FOUND_ROWS`.
124+
- Added a new configuration ``foundRows`` for MySQLi to use ``MYSQLI_CLIENT_FOUND_ROWS``.
125125

126126
Model
127127
=====

0 commit comments

Comments
 (0)