Merge pull request #5000 from samsonasik/remove-double-assign

[Rector] Apply Rector: RemoveDoubleAssignRector

Author: samsonasik

rector.php

@@ -28,6 +28,7 @@
 use Rector\Core\Configuration\Option;
 use Rector\Core\ValueObject\PhpVersion;
 use Rector\DeadCode\Rector\Array_\RemoveDuplicatedArrayKeyRector;
+use Rector\DeadCode\Rector\Assign\RemoveDoubleAssignRector;
 use Rector\DeadCode\Rector\Assign\RemoveUnusedVariableAssignRector;
 use Rector\DeadCode\Rector\Concat\RemoveConcatAutocastRector;
 use Rector\DeadCode\Rector\Foreach_\RemoveUnusedForeachKeyRector;
@@ -113,4 +114,5 @@
     $services->set(FuncGetArgsToVariadicParamRector::class);
     $services->set(MakeInheritedMethodVisibilitySameAsParentRector::class);
     $services->set(RemoveDuplicatedArrayKeyRector::class);
+    $services->set(RemoveDoubleAssignRector::class);
 };

tests/system/HTTP/IncomingRequestDetectingTest.php

@@ -152,7 +152,6 @@ public function testPathPathInfo()
 
     public function testPathPathInfoGlobal()
     {
-        $this->request->uri = '/index.php/woot?code=good#pos';
         $this->request->uri = '/index.php/woot?code=good#pos';
         $this->request->setGlobal('server', [
             'PATH_INFO' => 'silliness',