Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fortran] Replace archaic intrinsic functions #37

Open
RRiva opened this issue Sep 20, 2024 · 1 comment
Open

[Fortran] Replace archaic intrinsic functions #37

RRiva opened this issue Sep 20, 2024 · 1 comment

Comments

@RRiva
Copy link

RRiva commented Sep 20, 2024

Over time, several intrinsic functions have been labeled archaic. See here for the complete list. They should be replaced by their modern equivalent. For example: dsin works for real, while csin and zsin for complex of different kind. They should be replaced by sin, which works for all cases.

@alvrogd
Copy link
Collaborator

alvrogd commented Sep 20, 2024

Hi @RRiva,

Thank you once again for your continued contributions to improving the Open Catalog!

We didn’t have a specific check idea on our radar for this suggestion, but it certainly aligns with the Fortran modernization efforts. From what you’ve mentioned, it sounds like using these archaic functions doesn’t necessarily cause compilation failures (e.g., dsin and csin are in the F77 standard), but they could complicate maintenance, especially when refactoring code and changing data types.

As with your previous suggestions, if you're interested, feel free to open a PR proposing an entry for this check in the Open Catalog, following the tips shared in #36. Naturally, if you'd prefer, just let us know and we’ll be happy to take care of it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants