Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate extra await settled and await animationsSettled calls in tests #1011

Open
VasylMarchuk opened this issue Nov 22, 2023 · 1 comment
Open

Investigate extra await settled and await animationsSettled calls in tests #1011

VasylMarchuk opened this issue Nov 22, 2023 · 1 comment
Assignees
@VasylMarchuk

Comments

@VasylMarchuk
Copy link
Collaborator

VasylMarchuk commented Nov 22, 2023 •
edited
Loading

Brief

Several tests require explicit extra await settled and/or await animationsSettled calls, even when using only settled-aware methods and after properly awaiting on them.

Details
@VasylMarchuk VasylMarchuk added the sweep Assigns Sweep to an issue or pull request. label Nov 22, 2023
@VasylMarchuk VasylMarchuk self-assigned this Nov 22, 2023
@rohitpaulk rohitpaulk removed the sweep Assigns Sweep to an issue or pull request. label Dec 12, 2023
@VasylMarchuk
Copy link
Collaborator Author

It appears that if we properly use https://www.npmjs.com/package/@ember/test-waiters in our components, this problem will be fixed, or at least will become much more manageable.

@VasylMarchuk VasylMarchuk mentioned this issue Jul 13, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VasylMarchuk VasylMarchuk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@VasylMarchuk @rohitpaulk