From b2c540536577456dec9280317fccc56c1d50be47 Mon Sep 17 00:00:00 2001
From: joseph-sentry <136376984+joseph-sentry@users.noreply.github.com>
Date: Tue, 17 Sep 2024 11:29:02 -0400
Subject: [PATCH] fix: detected flake log (#714)

---
 tasks/test_results_finisher.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tasks/test_results_finisher.py b/tasks/test_results_finisher.py
index 4ee190f90..9ac64a797 100644
--- a/tasks/test_results_finisher.py
+++ b/tasks/test_results_finisher.py
@@ -352,7 +352,7 @@ def process_impl_within_lock(
             case _:
                 success = False
 
-        if flaky_tests is not None:
+        if len(flaky_tests):
             log.info(
                 "Detected failure on test that has been identified as flaky",
                 extra=dict(
@@ -362,6 +362,7 @@ def process_impl_within_lock(
                     test_ids=list(flaky_tests.keys()),
                 ),
             )
+            metrics.incr("test_results.finisher.detected_flaky_test")
 
         self.extra_dict["success"] = success
         log.info(