From 191e551504d70b8aa6985049d4ff8b47da481059 Mon Sep 17 00:00:00 2001 From: scott-codecov Date: Fri, 8 Sep 2023 12:46:33 -0400 Subject: [PATCH] Revert "Move feedback link out of footer section and always include at the bottom of a comment" --- .../notifiers/mixins/message/__init__.py | 22 ----- .../notifiers/mixins/message/sections.py | 17 +++- .../tests/integration/test_comment.py | 6 +- .../notifiers/tests/unit/test_checks.py | 3 - .../notifiers/tests/unit/test_comment.py | 82 ++++++++++++------- tasks/tests/integration/test_notify_task.py | 1 - 6 files changed, 72 insertions(+), 59 deletions(-) diff --git a/services/notification/notifiers/mixins/message/__init__.py b/services/notification/notifiers/mixins/message/__init__.py index 2bb333f61..0df9debf8 100644 --- a/services/notification/notifiers/mixins/message/__init__.py +++ b/services/notification/notifiers/mixins/message/__init__.py @@ -156,8 +156,6 @@ async def create_message( section_writer, ) - await self._write_feedback_link(comparison, settings, write) - return [m for m in message if m is not None] async def _possibly_write_gh_app_login_announcement( @@ -174,26 +172,6 @@ async def _possibly_write_gh_app_login_announcement( write(f":exclamation: {message_to_display}") write("") - async def _write_feedback_link( - self, comparison: ComparisonProxy, settings: dict, write: Callable - ): - hide_project_coverage = settings.get("hide_project_coverage", False) - if hide_project_coverage: - write( - ":loudspeaker: Thoughts on this report? [Let us know!]({0}).".format( - "https://about.codecov.io/pull-request-comment-report/" - ) - ) - else: - repo_service = comparison.repository_service.service - write( - ":loudspeaker: Have feedback on the report? [Share it here]({0}).".format( - "https://gitlab.com/codecov-open-source/codecov-user-feedback/-/issues/4" - if repo_service == "gitlab" - else "https://about.codecov.io/codecov-pr-comment-feedback/" - ) - ) - async def write_section_to_msg( self, comparison, changes, diff, links, write, section_writer, behind_by=None ): diff --git a/services/notification/notifiers/mixins/message/sections.py b/services/notification/notifiers/mixins/message/sections.py index fb10fe4a5..4754c8203 100644 --- a/services/notification/notifiers/mixins/message/sections.py +++ b/services/notification/notifiers/mixins/message/sections.py @@ -81,13 +81,28 @@ async def write_section(*args, **kwargs): class NewFooterSectionWriter(BaseSectionWriter): async def do_write_section(self, comparison, diff, changes, links, behind_by=None): hide_project_coverage = self.settings.get("hide_project_coverage", False) - if not hide_project_coverage: + if hide_project_coverage: + yield ("") + yield ( + ":loudspeaker: Thoughts on this report? [Let us know!]({0}).".format( + "https://about.codecov.io/pull-request-comment-report/" + ) + ) + else: + repo_service = comparison.repository_service.service yield ("") yield ( "[:umbrella: View full report in Codecov by Sentry]({0}?src=pr&el=continue). ".format( links["pull"] ) ) + yield ( + ":loudspeaker: Have feedback on the report? [Share it here]({0}).".format( + "https://about.codecov.io/codecov-pr-comment-feedback/" + if repo_service == "github" + else "https://gitlab.com/codecov-open-source/codecov-user-feedback/-/issues/4" + ) + ) class NewHeaderSectionWriter(BaseSectionWriter): diff --git a/services/notification/notifiers/tests/integration/test_comment.py b/services/notification/notifiers/tests/integration/test_comment.py index 2d5f205cb..0af653359 100644 --- a/services/notification/notifiers/tests/integration/test_comment.py +++ b/services/notification/notifiers/tests/integration/test_comment.py @@ -390,7 +390,6 @@ async def test_notify(self, sample_comparison, codecov_vcr, mock_configuration): "> `Δ = absolute (impact)`, `ø = not affected`, `? = missing data`", "> Powered by [Codecov](https://app.codecov.io/gh/joseph-sentry/codecov-demo/pull/9?src=pr&el=footer). Last update [5b174c2...5601846](https://app.codecov.io/gh/joseph-sentry/codecov-demo/pull/9?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).", "", - f":loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/).", ] for exp, res in zip(result.data_sent["message"], message): assert exp == res @@ -534,7 +533,6 @@ async def test_notify_gitlab( "> `Δ = absolute (impact)`, `ø = not affected`, `? = missing data`", "> Powered by [Codecov](https://app.codecov.io/gl/joseph-sentry/example-python/pull/1?src=pr&el=footer). Last update [0fc784a...0b6a213](https://app.codecov.io/gl/joseph-sentry/example-python/pull/1?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).", "", - f":loudspeaker: Have feedback on the report? [Share it here](https://gitlab.com/codecov-open-source/codecov-user-feedback/-/issues/4).", ] for exp, res in zip(result.data_sent["message"], message): assert exp == res @@ -602,8 +600,8 @@ async def test_notify_new_layout( "", "", "[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/joseph-sentry/codecov-demo/pull/9?src=pr&el=continue). ", - "", ":loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/).", + "", ] for exp, res in zip(result.data_sent["message"], message): assert exp == res @@ -682,8 +680,8 @@ async def test_notify_with_components( "", "", "[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/joseph-sentry/codecov-demo/pull/9?src=pr&el=continue). ", - "", ":loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/).", + "", ] for exp, res in zip(result.data_sent["message"], message): assert exp == res diff --git a/services/notification/notifiers/tests/unit/test_checks.py b/services/notification/notifiers/tests/unit/test_checks.py index 4491a5cef..d3704e661 100644 --- a/services/notification/notifiers/tests/unit/test_checks.py +++ b/services/notification/notifiers/tests/unit/test_checks.py @@ -1516,7 +1516,6 @@ async def test_build_default_payload( f"", f"... and [1 file with indirect coverage changes](test.example.br/gh/test_build_default_payload/{repo.name}/pull/{sample_comparison.pull.pullid}/indirect-changes?src=pr&el=tree-more)", f"", - ":loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/).", ] ), }, @@ -1559,7 +1558,6 @@ async def test_build_default_payload_with_flags( f"", f"... and [1 file with indirect coverage changes](test.example.br/gh/test_build_default_payload_with_flags/{repo.name}/pull/{sample_comparison.pull.pullid}/indirect-changes?src=pr&el=tree-more)", f"", - ":loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/).", ] ), }, @@ -1610,7 +1608,6 @@ async def test_build_default_payload_with_flags_and_footer( f"> `Δ = absolute (impact)`, `ø = not affected`, `? = missing data`", f"> Powered by [Codecov](test.example.br/gh/{test_name}/{repo.name}/pull/{sample_comparison.pull.pullid}?src=pr&el=footer). Last update [{base_commit.commitid[:7]}...{head_commit.commitid[:7]}](test.example.br/gh/{test_name}/{repo.name}/pull/{sample_comparison.pull.pullid}?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).", f"", - ":loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/).", ] ), }, diff --git a/services/notification/notifiers/tests/unit/test_comment.py b/services/notification/notifiers/tests/unit/test_comment.py index 8029f8dfe..e44f83413 100644 --- a/services/notification/notifiers/tests/unit/test_comment.py +++ b/services/notification/notifiers/tests/unit/test_comment.py @@ -713,7 +713,6 @@ async def test_create_message_files_section( f"| [file\\_1.go](https://app.codecov.io/gh/{repository.slug}/pull/{pull.pullid}?src=pr&el=tree#diff-ZmlsZV8xLmdv) | `62.50% <ø> (+12.50%)` | `10.00 <0.00> (-1.00)` | :arrow_up: |", f"| [file\\_2.py](https://app.codecov.io/gh/{repository.slug}/pull/{pull.pullid}?src=pr&el=tree#diff-ZmlsZV8yLnB5) | `50.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |", f"", - f":loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/).", ] res = await notifier.create_message(comparison, pull_dict, {"layout": "files"}) print(res) @@ -874,7 +873,6 @@ async def test_create_message_files_section_with_critical_files( f"| [file\\_2.py](https://app.codecov.io/gh/{repository.slug}/pull/{pull.pullid}?src=pr&el=tree#diff-ZmlsZV8yLnB5) **Critical** | `50.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |", f"", "", - f":loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/).", ] res = await notifier.build_message(comparison) assert expected_result == res @@ -948,7 +946,6 @@ async def test_build_message( f"[{sample_comparison.base.commit.commitid[:7]}...{sample_comparison.head.commit.commitid[:7]}](test.example.br/gh/{repository.slug}/pull/{pull.pullid}?src=pr&el=lastupdated). " f"Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).", f"", - f":loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/).", ] for exp, res in zip(expected_result, result): assert exp == res @@ -992,7 +989,6 @@ async def test_build_message_flags_empty_coverage( "", "Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.", "", - f":loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/).", ] li = 0 print("\n".join(result)) @@ -1083,7 +1079,6 @@ async def test_build_message_more_sections( f"", f"", f"", - f":loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/).", ] for exp, res in zip(expected_result, result): assert exp == res @@ -1343,7 +1338,6 @@ async def test_build_message_hide_complexity( f"[{sample_comparison.base.commit.commitid[:7]}...{sample_comparison.head.commit.commitid[:7]}](test.example.br/gh/{repository.slug}/pull/{pull.pullid}?src=pr&el=lastupdated). " f"Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).", f"", - f":loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/).", ] for exp, res in zip(expected_result, result): assert exp == res @@ -1415,7 +1409,6 @@ async def test_build_message_no_base_report( f"[{comparison.base.commit.commitid[:7]}...{comparison.head.commit.commitid[:7]}](test.example.br/gh/{repository.slug}/pull/{pull.pullid}?src=pr&el=lastupdated). " f"Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).", f"", - f":loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/).", ] for exp, res in zip(expected_result, result): assert exp == res @@ -1484,7 +1477,6 @@ async def test_build_message_no_base_commit( f"[cdf9aa4...{comparison.head.commit.commitid[:7]}](test.example.br/gh/{repository.slug}/pull/{pull.pullid}?src=pr&el=lastupdated). " f"Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).", f"", - f":loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/).", ] for exp, res in zip(expected_result, result): assert exp == res @@ -1558,7 +1550,6 @@ async def test_build_message_no_change( f"[{sample_comparison_no_change.base.commit.commitid[:7]}...{sample_comparison_no_change.head.commit.commitid[:7]}](test.example.br/gh/{repository.slug}/pull/{pull.pullid}?src=pr&el=lastupdated). " f"Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).", f"", - f":loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/).", ] print(result) li = 0 @@ -1637,7 +1628,6 @@ async def test_build_message_negative_change( f"[{comparison.base.commit.commitid[:7]}...{comparison.head.commit.commitid[:7]}](test.example.br/gh/{repository.slug}/pull/{pull.pullid}?src=pr&el=lastupdated). " f"Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).", f"", - f":loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/).", ] print(result) for exp, res in zip(expected_result, result): @@ -1702,7 +1692,6 @@ async def test_build_message_negative_change_tricky_rounding( f"- Misses 871 874 +3 ", f"```", f"", - f":loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/).", ] print(result) li = 0 @@ -1757,7 +1746,6 @@ async def test_build_message_negative_change_tricky_rounding_newheader( f"Patch coverage has no change and project coverage change: **`-0.04%`** :warning:", f"> Comparison is base [(`{comparison.base.commit.commitid[:7]}`)](test.example.br/gh/{repository.slug}/commit/{comparison.base.commit.commitid}?el=desc) 88.58% compared to head [(`{comparison.head.commit.commitid[:7]}`)](test.example.br/gh/{repository.slug}/pull/{pull.pullid}?src=pr&el=desc) 88.54%.", f"", - f":loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/).", ] print(result) li = 0 @@ -1833,7 +1821,6 @@ async def test_build_message_show_carriedforward_flags_no_cf_coverage( f"[{sample_comparison.base.commit.commitid[:7]}...{sample_comparison.head.commit.commitid[:7]}](test.example.br/gh/{repository.slug}/pull/{pull.pullid}?src=pr&el=lastupdated). " f"Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).", f"", - f":loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/).", ] for exp, res in zip(expected_result, result): assert exp == res @@ -1898,7 +1885,6 @@ async def test_build_message_with_without_flags( f"[{comparison.base.commit.commitid[:7]}...{comparison.head.commit.commitid[:7]}](test.example.br/gh/{repository.slug}/pull/{pull.pullid}?src=pr&el=lastupdated). " f"Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).", f"", - f":loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/).", ] print(result) li = 0 @@ -1968,7 +1954,6 @@ async def test_build_message_with_without_flags( f"[{comparison.base.commit.commitid[:7]}...{comparison.head.commit.commitid[:7]}](test.example.br/gh/{repository.slug}/pull/{pull.pullid}?src=pr&el=lastupdated). " f"Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).", f"", - f":loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/).", ] print(result) li = 0 @@ -2045,7 +2030,6 @@ async def test_build_message_show_carriedforward_flags_has_cf_coverage( f"[{comparison.base.commit.commitid[:7]}...{comparison.head.commit.commitid[:7]}](test.example.br/gh/{repository.slug}/pull/{pull.pullid}?src=pr&el=lastupdated). " f"Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).", f"", - f":loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/).", ] print(result) li = 0 @@ -2120,7 +2104,6 @@ async def test_build_message_hide_carriedforward_flags_has_cf_coverage( f"[{comparison.base.commit.commitid[:7]}...{comparison.head.commit.commitid[:7]}](test.example.br/gh/{repository.slug}/pull/{pull.pullid}?src=pr&el=lastupdated). " f"Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).", f"", - f":loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/).", ] print(result) li = 0 @@ -2228,7 +2211,6 @@ async def test_build_message_no_flags( f"[{comparison.base.commit.commitid[:7]}...{comparison.head.commit.commitid[:7]}](test.example.br/gh/{repository.slug}/pull/{pull.pullid}?src=pr&el=lastupdated). " f"Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).", f"", - f":loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/).", ] for exp, res in zip(expected_result, result): assert exp == res @@ -3246,7 +3228,6 @@ async def test_message_hide_details_github( f"[![Impacted file tree graph](test.example.br/gh/{repository.slug}/pull/{pull.pullid}/graphs/tree.svg?width=650&height=150&src=pr&token={repository.image_token})](test.example.br/gh/{repository.slug}/pull/{pull.pullid}?src=pr&el=tree)", f"", f"", - f":loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/).", ] li = 0 for exp, res in zip(expected_result, result): @@ -3279,7 +3260,6 @@ async def test_message_announcements_only( "", ":mega: message", "", - f":loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/).", ] for exp, res in zip(expected_result, result): if exp == ":mega: message": @@ -3317,7 +3297,6 @@ async def test_message_hide_details_bitbucket( f"", f"[![Impacted file tree graph](test.example.br/gh/{repository.slug}/pull/{pull.pullid}/graphs/tree.svg?width=650&height=150&src=pr&token={repository.image_token})](test.example.br/gh/{repository.slug}/pull/{pull.pullid}?src=pr&el=tree)", f"", - f":loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/).", ] li = 0 for exp, res in zip(expected_result, result): @@ -3823,6 +3802,51 @@ async def test_footer_section_writer_in_github(self, mocker): assert res == [ "", "[:umbrella: View full report in Codecov by Sentry](pull.link?src=pr&el=continue). ", + ":loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/).", + ] + + @pytest.mark.asyncio + async def test_footer_section_writer_in_gitlab(self, mocker): + writer = NewFooterSectionWriter( + mocker.MagicMock(), + mocker.MagicMock(), + mocker.MagicMock(), + settings={}, + current_yaml=mocker.MagicMock(), + ) + mock_comparison = mocker.MagicMock() + mock_comparison.repository_service.service = "gitlab" + res = list( + await writer.write_section( + mock_comparison, {}, [], links={"pull": "pull.link"} + ) + ) + assert res == [ + "", + "[:umbrella: View full report in Codecov by Sentry](pull.link?src=pr&el=continue). ", + ":loudspeaker: Have feedback on the report? [Share it here](https://gitlab.com/codecov-open-source/codecov-user-feedback/-/issues/4).", + ] + + @pytest.mark.asyncio + async def test_footer_section_writer_in_bitbucket(self, mocker): + writer = NewFooterSectionWriter( + mocker.MagicMock(), + mocker.MagicMock(), + mocker.MagicMock(), + settings={}, + current_yaml=mocker.MagicMock(), + ) + mock_comparison = mocker.MagicMock() + mock_comparison.repository_service.service = "bitbucket" + res = list( + await writer.write_section( + mock_comparison, {}, [], links={"pull": "pull.link"} + ) + ) + assert res == [ + "", + "[:umbrella: View full report in Codecov by Sentry](pull.link?src=pr&el=continue). ", + ":loudspeaker: Have feedback on the report? [Share it here](https://gitlab.com/codecov-open-source/codecov-user-feedback/-/issues/4).", ] @pytest.mark.asyncio @@ -3844,7 +3868,10 @@ async def test_footer_section_writer_with_project_cov_hidden(self, mocker): mock_comparison, {}, [], links={"pull": "pull.link"} ) ) - assert res == [] + assert res == [ + "", + ":loudspeaker: Thoughts on this report? [Let us know!](https://about.codecov.io/pull-request-comment-report/).", + ] @pytest.mark.usefixtures("is_not_first_pull") @@ -4004,7 +4031,6 @@ async def test_create_message_files_section_with_critical_files_new_layout( f"| [file\\_2.py](https://app.codecov.io/gh/{repository.slug}/pull/{pull.pullid}?src=pr&el=tree#diff-ZmlsZV8yLnB5) **Critical** | `50.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |", f"", "", - f":loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/).", ] res = await notifier.build_message(comparison) assert expected_result == res @@ -4068,8 +4094,8 @@ async def test_build_message_no_base_commit_new_layout( f"", f"", f"[:umbrella: View full report in Codecov by Sentry](test.example.br/gh/{repository.slug}/pull/{pull.pullid}?src=pr&el=continue). ", - f"", f":loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/).", + f"", ] for exp, res in zip(expected_result, result): assert exp == res @@ -4138,8 +4164,8 @@ async def test_build_message_no_base_report_new_layout( f"", f"", f"[:umbrella: View full report in Codecov by Sentry](test.example.br/gh/{repository.slug}/pull/{pull.pullid}?src=pr&el=continue). ", - f"", f":loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/).", + f"", ] for exp, res in zip(expected_result, result): assert exp == res @@ -4179,6 +4205,7 @@ async def test_build_message_no_project_coverage( f"", f"", f":loudspeaker: Thoughts on this report? [Let us know!](https://about.codecov.io/pull-request-comment-report/).", + f"", ] for exp, res in zip(expected_result, result): assert exp == res @@ -4245,8 +4272,8 @@ async def test_build_message_head_and_pull_head_differ_new_layout( f"", f"", f"[:umbrella: View full report in Codecov by Sentry](test.example.br/gh/{repository.slug}/pull/{pull.pullid}?src=pr&el=continue). ", - f"", f":loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/).", + f"", ] for exp, res in zip(expected_result, result): assert exp == res @@ -4325,8 +4352,8 @@ async def test_build_message_head_and_pull_head_differ_with_components( f"", f"", f"[:umbrella: View full report in Codecov by Sentry](test.example.br/gh/{repository.slug}/pull/{pull.pullid}?src=pr&el=continue). ", - f"", f":loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/).", + f"", ] for exp, res in zip(expected_result, result): assert exp == res @@ -4396,7 +4423,6 @@ async def test_build_message_no_patch_or_proj_change( f"[{comparison.base.commit.commitid[:7]}...{comparison.head.commit.commitid[:7]}](test.example.br/gh/{repository.slug}/pull/{pull.pullid}?src=pr&el=lastupdated). " f"Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).", f"", - f":loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/).", ] for exp, res in zip(expected_result, result): diff --git a/tasks/tests/integration/test_notify_task.py b/tasks/tests/integration/test_notify_task.py index a94acdcc2..c5c083a10 100644 --- a/tasks/tests/integration/test_notify_task.py +++ b/tasks/tests/integration/test_notify_task.py @@ -1193,7 +1193,6 @@ async def test_simple_call_status_and_notifiers( "> `Δ = absolute (impact)`, `ø = not affected`, `? = missing data`", "> Powered by [Codecov](https://myexamplewebsite.io/gh/joseph-sentry/codecov-demo/pull/9?src=pr&el=footer). Last update [5b174c2...5601846](https://myexamplewebsite.io/gh/joseph-sentry/codecov-demo/pull/9?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).", "", - ":loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/).", ], "commentid": None, "pullid": 9,