Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update copy for GitHub app in PR comment #370

Closed
Tracked by #199
codecovdesign opened this issue Aug 16, 2023 · 3 comments
Closed
Tracked by #199

Update copy for GitHub app in PR comment #370

codecovdesign opened this issue Aug 16, 2023 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@codecovdesign
Copy link
Contributor

codecovdesign commented Aug 16, 2023

Problem to solve

The PR comment shows a GitHub app warning – that is a bit outdated (May 15th).
image (7)

Solution

TBD, alternative: remove message from PR comment

@codecovdesign
Copy link
Contributor Author

another report: codecov/feedback#8 (comment)
looks like the app was already installed for the user, but the message was still shown

@scott-codecov
Copy link

scott-codecov commented Sep 5, 2023

The only condition under which we display this message is if repo owner's integration_id is null: https://github.com/codecov/worker/blob/8012c86931021e5c39df7f5ae9a8ec9db1f33cee/services/notification/notifiers/mixins/message/__init__.py#L166-L173

Looking at the code I see the following log line emitted after we save the integration_id (in the webhook handler): https://github.com/codecov/codecov-api/blob/958cfcf1d3ec092371ba4c9cae0020c33a1bf624/webhook_handlers/views/github.py#L424

Searching for that log line in GCP only yields a single result on 9/3/2023:
https://l.codecov.dev/EELWfJ. And subsequent PRs in that same repo no longer display the warning.

We must have missed the original webhook to install the app for CLIENT. This must be a fairly common occurrence since we already have a task to ask for missed webhooks and request redelivery: https://github.com/codecov/worker/blob/main/tasks/github_app_webhooks_check.py

There's been talk about rebuilding some of the infrastructure around webhooks in hopes of missing fewer requests. Aside from that I'm not entirely sure what else to do at this point.

@scott-codecov
Copy link

I will make a PR with the copy change suggested above though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants