Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement GH Check Caching #350

Closed
trent-codecov opened this issue Aug 14, 2023 · 0 comments · Fixed by codecov/worker#74
Closed

Implement GH Check Caching #350

trent-codecov opened this issue Aug 14, 2023 · 0 comments · Fixed by codecov/worker#74
Assignees
Labels
enhancement New feature or request

Comments

@trent-codecov
Copy link
Contributor

Research: https://github.com/codecov/worker-archive/issues/1205

We needlessly update GH checks many times.

Please implement caching scheme to cache last update and avoid sending sequential duplicates.

High level pseudocode to use as at least some inspiration

new_patch_val = 'the new patch value'
cache_val = get_cache(patch_id)
if cache_val && cache_val == new_patch_val
  put_cache(patch_id, new_patch_val, SOME_EXPIRATION)
else
  put_cache(patch_id, new_patch_val, SOME_EXPIRATION)
  send_github_check(patch_id, new_patch_val)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants