Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line mismatch when a file has both direct and indirect changes [PR Details Page] #3030

Open
aj-codecov opened this issue Nov 27, 2024 · 0 comments
Labels
Area: PR Comment - UX Issues with the PR Comment UX bug Something isn't working Design-Ready Issue is with design: discovery, solution, prep for dev

Comments

@aj-codecov
Copy link

aj-codecov commented Nov 27, 2024

Describe the issue
When a file has both direct and indirect coverage changes in Codecov we show a message about how many lines are missing from the patch coverage. When you unfurl the coverage section you then see the total number of lines missed in that file (in the screenshot you go from 21 to 95). This feels pretty jarring. When you then click into the file itself to see line by line coverage, you see chunks relative to the patch, but you also see the missed lines relative to the indirect coverage change.

First screenshot showing the number discrepancy between header and in line missed line numbers.
Image

Second screenshot showing the indirect tab where the file also exists (and has 95 missing lines)
Image

Third screenshot showing the chunks of patch AND indirect changes all thrown together.
Image

Pull Request Link

Proposed Solution:
This could be handled a few ways and is worth a discussion:

  1. We could only count the number of lines relative to the patch in the direct changes tab and only show those in the table.
  2. We could make some sort of notation about how the file contains both direct and indirect coverage info.
  3. We could annotate each line as direct or indirect.
  4. Something else?
@aj-codecov aj-codecov added Area: PR Comment - UX Issues with the PR Comment UX bug Something isn't working Design-Ready Issue is with design: discovery, solution, prep for dev and removed bug Something isn't working labels Nov 27, 2024
@codecov-hooky codecov-hooky bot added the bug Something isn't working label Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: PR Comment - UX Issues with the PR Comment UX bug Something isn't working Design-Ready Issue is with design: discovery, solution, prep for dev
Projects
None yet
Development

No branches or pull requests

1 participant