Line mismatch when a file has both direct and indirect changes [PR Details Page] #3030
Labels
Area: PR Comment - UX
Issues with the PR Comment UX
bug
Something isn't working
Design-Ready
Issue is with design: discovery, solution, prep for dev
Describe the issue
When a file has both direct and indirect coverage changes in Codecov we show a message about how many lines are missing from the patch coverage. When you unfurl the coverage section you then see the total number of lines missed in that file (in the screenshot you go from 21 to 95). This feels pretty jarring. When you then click into the file itself to see line by line coverage, you see chunks relative to the patch, but you also see the missed lines relative to the indirect coverage change.
First screenshot showing the number discrepancy between header and in line missed line numbers.
Second screenshot showing the indirect tab where the file also exists (and has 95 missing lines)
Third screenshot showing the chunks of patch AND indirect changes all thrown together.
Pull Request Link
Proposed Solution:
This could be handled a few ways and is worth a discussion:
The text was updated successfully, but these errors were encountered: