Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

double error message #3028

Closed
aj-codecov opened this issue Nov 27, 2024 · 0 comments · Fixed by codecov/gazebo#3590
Closed

double error message #3028

aj-codecov opened this issue Nov 27, 2024 · 0 comments · Fixed by codecov/gazebo#3590
Assignees
Labels
Area: General UX Issues with general UX bug Something isn't working Medium Medium Priority Issues (to be fixed or re-evaluated in 3 months

Comments

@aj-codecov
Copy link

Describe the bug
Duplicating error messages:
Image

To Reproduce
I got rate limited with an error message > kicked out to the login screen > logged back in > rate limited still with a double error message

Expected behavior
One error message screen

Additional context
Per Nick:
This error is arising because we have two network error boundaries that both display this logo, the optimal solution would most likely be to remove the logo and content/create a custom network error boundary component for the top components (global top banners & header) that doesn't display anything.

https://github.com/codecov/gazebo/blob/main/src/layouts/BaseLayout/BaseLayout.tsx#L88-L106

@aj-codecov aj-codecov added bug Something isn't working Area: General UX Issues with general UX labels Nov 27, 2024
@eliatcodecov eliatcodecov added the Medium Medium Priority Issues (to be fixed or re-evaluated in 3 months label Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: General UX Issues with general UX bug Something isn't working Medium Medium Priority Issues (to be fixed or re-evaluated in 3 months
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants