Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feedback solicitation #296

Closed
Tracked by #125
codecovdesign opened this issue Jul 26, 2023 · 3 comments
Closed
Tracked by #125

Feedback solicitation #296

codecovdesign opened this issue Jul 26, 2023 · 3 comments
Assignees
@scott-codecov

Comments

@codecovdesign
Copy link
Contributor

  • where to show
  • what % to show
@codecovdesign
Copy link
Contributor Author

feedback from @joseph-sentry

Right now, looking at the code, it's a part of the footer and if the footer is not enabled in the settings it won't include the solicitation for feedback in the comment, but my feeling is that this footer setting should be enabled for the most part so maybe something else is going on?

@codecovdesign codecovdesign mentioned this issue Jul 28, 2023
Open
@katia-sentry katia-sentry transferred this issue from another repository Aug 9, 2023
@scott-codecov
Copy link

@codecovdesign Could you expand a bit on what needs to be done here?

@scott-codecov scott-codecov mentioned this issue Sep 6, 2023
Merged
@codecov-hooky codecov-hooky bot closed this as completed Sep 8, 2023
@scott-codecov
Copy link

Reverting this for now based on feedback here: codecov/feedback#8 (comment)

Revert PR: codecov/worker#95

@scott-codecov scott-codecov mentioned this issue Sep 8, 2023
Merged
@adrian-codecov adrian-codecov mentioned this issue Sep 15, 2023
Closed
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scott-codecov scott-codecov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@codecovdesign @scott-codecov