Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move after_n_builds earlier in the report processing cycle. #1245

Open
rohan-at-sentry opened this issue Feb 22, 2024 · 5 comments
Open

Move after_n_builds earlier in the report processing cycle. #1245

rohan-at-sentry opened this issue Feb 22, 2024 · 5 comments
Labels
epic this label is used to mark issues as epics P2: stretch priority <=6

Comments

@rohan-at-sentry
Copy link

Discussed in codecov/feedback#204

Originally posted by drazisil-codecov December 27, 2023
Currently, after_n_builds is a notification setting that tells Codecov to only send comments and statuses after N uploads have been received.

This does not prevent Codecov for running coverage calculations early though, and those results will show in the Codecov UI.

The ask is for after_n_builds to also control if Codedcov runs the coverage calculation before the expected number of uploads are received. This would prevent expected bad information to be shown to the customer via any method.

@nhorton
Copy link

nhorton commented Dec 16, 2024

This is our biggest frustration with CodeCov right now. Note that I think it is also causing some other bugs. Ex. we have incorrect 'this line was not covered' comments in our PRs, and I am pretty sure it is because they get set by the first report and there is a race condition for fixing them with later reports coming in.

@ftakj
Copy link

ftakj commented Dec 16, 2024

+1 would like to see this resolved

@ncrmro
Copy link

ncrmro commented Dec 16, 2024

+1

@PabloScolpino
Copy link

This is currently causing distractions as we have split our code testing in a few processes for clarity. It would be very much appreciated if some attention was given to this.

@WanxinXia
Copy link

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
epic this label is used to mark issues as epics P2: stretch priority <=6
Projects
None yet
Development

No branches or pull requests

8 participants