deps: update shared #1173
deps: update shared #1173
Conversation
|
This PR includes changes to |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #1173 +/- ##
=======================================
Coverage 95.92% 95.92%
=======================================
Files 492 492
Lines 16876 16877 +1
=======================================
+ Hits 16188 16189 +1
Misses 688 688
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
joseph-sentry
temporarily deployed
to
staging
GitHub Actions
Inactive
joseph-sentry
force-pushed
the
joseph/update-shared
branch
from
f71a411 to
35094d4
Compare
joseph-sentry
force-pushed
the
joseph/update-shared
branch
from
35094d4 to
0c14dc9
Compare
|
This PR includes changes to |
| @@ -388,6 +388,7 @@ async def get_repo(self): | |||
| raise Http404("Requested report could not be found") | |||
| return repo | |||
|
|
|||
| @sync_to_async | |||
There was a problem hiding this comment.
this change looks unrelated. why?
if the function was sync all along, there is no reason to make it async? the function body looks trivial enough that it wouldn’t benefit from running concurrently.
| @@ -16,7 +16,7 @@ | |||
| def test_simple_static_analysis_call_no_uploads_yet(db, mocker): | |||
| mocked_task_service = mocker.patch.object(TaskService, "schedule_task") | |||
| mocked_presigned_put = mocker.patch( | |||
| "shared.api_archive.archive.StorageService.create_presigned_put", | |||
| "shared.storage.MinioStorageService.create_presigned_put", | |||
There was a problem hiding this comment.
as we have discussed in the retro, related to "overreliance on mocks", keep in mind that all of these mocks are potential breakage in production that we will never catch in tests :-(
No description provided.