Add a sunburst internal endpoint #1164
Conversation
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
📢 Thoughts on this report? Let us know! |
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #1164 +/- ##
==========================================
- Coverage 96.07% 96.01% -0.06%
==========================================
Files 836 836
Lines 19723 19742 +19
==========================================
+ Hits 18948 18955 +7
- Misses 775 787 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@ai-review-prompt-prod |
|
@codecov-ai-reviewer |
|
@codecov-ai-reviewer review |
|
On it! We are reviewing the PR and will provide feedback shortly. |
![codecov-ai[bot]](https://avatars.githubusercontent.com/in/797565?s=60&v=4){kind=small}
|
|
||
| @action(detail=False, methods=["get"], url_path="sunburst") | ||
| def sunburst(self, request: HttpRequest, *args: Any, **kwargs: Any) -> Response: | ||
| paths = self.get_object() | ||
| serializer = SunburstSerializer(paths.single_directory(), many=True) | ||
| return Response(serializer.data) |
There was a problem hiding this comment.
To improve readability and maintainability, consider refactoring the sunburst method to avoid code duplication with the tree method. You can create a helper method to handle the common logic.
| @action(detail=False, methods=["get"], url_path="sunburst") | |
| def sunburst(self, request: HttpRequest, *args: Any, **kwargs: Any) -> Response: | |
| paths = self.get_object() | |
| serializer = SunburstSerializer(paths.single_directory(), many=True) | |
| return Response(serializer.data) | |
| def serialize_paths(self, serializer_class): | |
| paths = self.get_object() | |
| serializer = serializer_class(paths.single_directory(), many=True) | |
| return Response(serializer.data) | |
| @action(detail=False, methods=["get"], url_path="sunburst") | |
| def sunburst(self, request: HttpRequest, *args: Any, **kwargs: Any) -> Response: | |
| return self.serialize_paths(SunburstSerializer) |
|
No changes requiring review at this time. |
Make a copy of tree endpoint that returns a slightly different response structure:
coveragetovaluelines,hits,partials,missesOnce this new endpoint is proven effectively by the frontend we will delete /tree endpoint and migrate the tests to this endpoint as well
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.