Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requires cURL #349

Closed
mxcl opened this issue Jun 10, 2021 · 2 comments
Closed

Requires cURL #349

mxcl opened this issue Jun 10, 2021 · 2 comments

Comments

@mxcl
Copy link

mxcl commented Jun 10, 2021

This is pretty strange requirement considering this is a JavaScript action.

Either way you should at least specify this requirement in the README. It’s trivial to use this action in a Docker container that has no cURL.

However if you want some actual geek points, drop the requirement for cURL. Like aren’t you guys a profitable business?

@RA80533
Copy link
Contributor

RA80533 commented Jun 10, 2021

It might be best to file this over in codecov-bash since that's what's responsible for the area relating to Bash. It not quite clear to onlookers that this repo is basically two separate projects due to this, despite the Bash script appearing as a normal source file here.

@thomasrockhu
Copy link
Contributor

This should be resolved in v2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants