Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add network filter parameter #252

Merged
merged 1 commit into from
Mar 16, 2021
Merged

Add network filter parameter #252

merged 1 commit into from
Mar 16, 2021

Conversation

thomasrockhu
Copy link
Contributor

@thomasrockhu thomasrockhu commented Mar 16, 2021

Adds the network filter parameter used in the bash uploader

The parameter should be used to restrict the set of git files that can be matched with filenames in the coverage report. This is useful for monorepos or other setups where a full filepath may not be specified in the coverage report, and that shortened filepath may appear multiple times in a directory structure (e.g. __init__.py)

@codecov
Copy link

codecov bot commented Mar 16, 2021

Codecov Report

Merging #252 (79a0ba1) into master (1f8f3ab) will increase coverage by 0.78%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #252      +/-   ##
==========================================
+ Coverage   97.03%   97.82%   +0.78%     
==========================================
  Files           3        3              
  Lines         135      138       +3     
  Branches       41       42       +1     
==========================================
+ Hits          131      135       +4     
+ Misses          4        3       -1     
Flag Coverage Δ
demo 87.50% <ø> (ø)
script 99.18% <100.00%> (+0.86%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/buildExec.ts 99.18% <100.00%> (+0.86%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f8f3ab...79a0ba1. Read the comment docs.

Copy link
Contributor

@drazisil-codecov drazisil-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasrockhu thomasrockhu merged commit 6ed0d16 into master Mar 16, 2021
@thomasrockhu thomasrockhu deleted the 1.3.0 branch March 16, 2021 13:30
This was referenced Mar 16, 2021
This was referenced Mar 17, 2021
github-actions bot referenced this pull request in ros-tooling/libstatistics_collector Mar 31, 2021
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from v1.2.1 to v1.3.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/codecov/codecov-action/releases">codecov/codecov-action's releases</a>.</em></p>
<blockquote>
<h2>v1.3.1</h2>
<h2>1.3.1</h2>
<h3>Fixes</h3>
<ul>
<li><a href="https://github.com/codecov/codecov-action/issues/253">#253</a> Add <code>network_filter</code> to action manifest</li>
</ul>
<h2>v1.3.0</h2>
<h2>1.3.0</h2>
<h3>Features</h3>
<ul>
<li><a href="https://github.com/codecov/codecov-action/issues/252">#252</a> Add &quot;network_filter&quot; input</li>
</ul>
<h2>v1.2.2</h2>
<h3>Fixes</h3>
<ul>
<li><a href="https://github.com/codecov/codecov-action/issues/241">#241</a> pass root_dir using proper bash arg</li>
<li><a href="https://github.com/codecov/codecov-action/issues/244">#244</a> Overwrite the commit on pull_request* events</li>
</ul>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/codecov/codecov-action/blob/master/CHANGELOG.md">codecov/codecov-action's changelog</a>.</em></p>
<blockquote>
<h2>1.3.1</h2>
<h3>Fixes</h3>
<ul>
<li><a href="https://github.com/codecov/codecov-action/issues/253">#253</a> Add <code>network_filter</code> to action manifest</li>
</ul>
<h2>1.3.0</h2>
<h3>Features</h3>
<ul>
<li><a href="https://github.com/codecov/codecov-action/issues/252">#252</a> Add &quot;network_filter&quot; input</li>
</ul>
<h2>1.2.2</h2>
<h3>Fixes</h3>
<ul>
<li><a href="https://github.com/codecov/codecov-action/issues/241">#241</a> pass root_dir using proper bash arg</li>
<li><a href="https://github.com/codecov/codecov-action/issues/244">#244</a> Overwrite the commit on pull_request* events</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/codecov/codecov-action/commit/fcebab03f26c7530a22baa63f06b3e0515f0c7cd"><code>fcebab0</code></a> Merge pull request <a href="https://github.com/codecov/codecov-action/issues/253">#253</a> from codecov/1.3.1</li>
<li><a href="https://github.com/codecov/codecov-action/commit/7ea3ba9ac075d6b603dc17b37e2984a5fda6843b"><code>7ea3ba9</code></a> Add network_filter to manifest</li>
<li><a href="https://github.com/codecov/codecov-action/commit/6ed0d16b40c7d9a556bd123f0e7253be6ed081df"><code>6ed0d16</code></a> Merge pull request <a href="https://github.com/codecov/codecov-action/issues/252">#252</a> from codecov/1.3.0</li>
<li><a href="https://github.com/codecov/codecov-action/commit/79a0ba12c830bcfe66179a421069b588cb277952"><code>79a0ba1</code></a> Add network filter parameter</li>
<li><a href="https://github.com/codecov/codecov-action/commit/1f8f3abcccf7960749744fd13547965f0e7d1bdd"><code>1f8f3ab</code></a> Merge pull request <a href="https://github.com/codecov/codecov-action/issues/247">#247</a> from codecov/1.2.2</li>
<li><a href="https://github.com/codecov/codecov-action/commit/763298c6f68b6b2d4191362e8da948ad180b4299"><code>763298c</code></a> Update CHANGELOG.md</li>
<li><a href="https://github.com/codecov/codecov-action/commit/3207ad4e6013c331c40ac815c772d6e9714f5f77"><code>3207ad4</code></a> Merge pull request <a href="https://github.com/codecov/codecov-action/issues/241">#241</a> from jeffkenney/fix-root-dir-arg</li>
<li><a href="https://github.com/codecov/codecov-action/commit/ab3cfafc5bac7280958384264e1b954433cce9a7"><code>ab3cfaf</code></a> Bump to 1.2.2</li>
<li><a href="https://github.com/codecov/codecov-action/commit/b708b7e81f3f8e04728cc8e1b1ad83735f01101f"><code>b708b7e</code></a> Merge pull request <a href="https://github.com/codecov/codecov-action/issues/244">#244</a> from codecov/override-fetch-depth</li>
<li><a href="https://github.com/codecov/codecov-action/commit/65f43cece2c52d3e87256602f328dc0cdd5ef4df"><code>65f43ce</code></a> actually</li>
<li>Additional commits viewable in <a href="https://github.com/codecov/codecov-action/compare/v1.2.1...fcebab03f26c7530a22baa63f06b3e0515f0c7cd">compare view</a></li>
</ul>
</details>
<br />


Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)


</details>
github-actions bot referenced this pull request in ros-tooling/launch_ros_sandbox Mar 31, 2021
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from v1.2.1 to v1.3.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/codecov/codecov-action/releases">codecov/codecov-action's releases</a>.</em></p>
<blockquote>
<h2>v1.3.1</h2>
<h2>1.3.1</h2>
<h3>Fixes</h3>
<ul>
<li><a href="https://github.com/codecov/codecov-action/issues/253">#253</a> Add <code>network_filter</code> to action manifest</li>
</ul>
<h2>v1.3.0</h2>
<h2>1.3.0</h2>
<h3>Features</h3>
<ul>
<li><a href="https://github.com/codecov/codecov-action/issues/252">#252</a> Add &quot;network_filter&quot; input</li>
</ul>
<h2>v1.2.2</h2>
<h3>Fixes</h3>
<ul>
<li><a href="https://github.com/codecov/codecov-action/issues/241">#241</a> pass root_dir using proper bash arg</li>
<li><a href="https://github.com/codecov/codecov-action/issues/244">#244</a> Overwrite the commit on pull_request* events</li>
</ul>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/codecov/codecov-action/blob/master/CHANGELOG.md">codecov/codecov-action's changelog</a>.</em></p>
<blockquote>
<h2>1.3.1</h2>
<h3>Fixes</h3>
<ul>
<li><a href="https://github.com/codecov/codecov-action/issues/253">#253</a> Add <code>network_filter</code> to action manifest</li>
</ul>
<h2>1.3.0</h2>
<h3>Features</h3>
<ul>
<li><a href="https://github.com/codecov/codecov-action/issues/252">#252</a> Add &quot;network_filter&quot; input</li>
</ul>
<h2>1.2.2</h2>
<h3>Fixes</h3>
<ul>
<li><a href="https://github.com/codecov/codecov-action/issues/241">#241</a> pass root_dir using proper bash arg</li>
<li><a href="https://github.com/codecov/codecov-action/issues/244">#244</a> Overwrite the commit on pull_request* events</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/codecov/codecov-action/commit/fcebab03f26c7530a22baa63f06b3e0515f0c7cd"><code>fcebab0</code></a> Merge pull request <a href="https://github.com/codecov/codecov-action/issues/253">#253</a> from codecov/1.3.1</li>
<li><a href="https://github.com/codecov/codecov-action/commit/7ea3ba9ac075d6b603dc17b37e2984a5fda6843b"><code>7ea3ba9</code></a> Add network_filter to manifest</li>
<li><a href="https://github.com/codecov/codecov-action/commit/6ed0d16b40c7d9a556bd123f0e7253be6ed081df"><code>6ed0d16</code></a> Merge pull request <a href="https://github.com/codecov/codecov-action/issues/252">#252</a> from codecov/1.3.0</li>
<li><a href="https://github.com/codecov/codecov-action/commit/79a0ba12c830bcfe66179a421069b588cb277952"><code>79a0ba1</code></a> Add network filter parameter</li>
<li><a href="https://github.com/codecov/codecov-action/commit/1f8f3abcccf7960749744fd13547965f0e7d1bdd"><code>1f8f3ab</code></a> Merge pull request <a href="https://github.com/codecov/codecov-action/issues/247">#247</a> from codecov/1.2.2</li>
<li><a href="https://github.com/codecov/codecov-action/commit/763298c6f68b6b2d4191362e8da948ad180b4299"><code>763298c</code></a> Update CHANGELOG.md</li>
<li><a href="https://github.com/codecov/codecov-action/commit/3207ad4e6013c331c40ac815c772d6e9714f5f77"><code>3207ad4</code></a> Merge pull request <a href="https://github.com/codecov/codecov-action/issues/241">#241</a> from jeffkenney/fix-root-dir-arg</li>
<li><a href="https://github.com/codecov/codecov-action/commit/ab3cfafc5bac7280958384264e1b954433cce9a7"><code>ab3cfaf</code></a> Bump to 1.2.2</li>
<li><a href="https://github.com/codecov/codecov-action/commit/b708b7e81f3f8e04728cc8e1b1ad83735f01101f"><code>b708b7e</code></a> Merge pull request <a href="https://github.com/codecov/codecov-action/issues/244">#244</a> from codecov/override-fetch-depth</li>
<li><a href="https://github.com/codecov/codecov-action/commit/65f43cece2c52d3e87256602f328dc0cdd5ef4df"><code>65f43ce</code></a> actually</li>
<li>Additional commits viewable in <a href="https://github.com/codecov/codecov-action/compare/v1.2.1...fcebab03f26c7530a22baa63f06b3e0515f0c7cd">compare view</a></li>
</ul>
</details>
<br />


Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)


</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants