Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error: Runner "composite" does not implemented after upgrade to v5 #1719

Closed
f0uriest opened this issue Dec 10, 2024 · 4 comments
Closed

Error: Runner "composite" does not implemented after upgrade to v5 #1719

f0uriest opened this issue Dec 10, 2024 · 4 comments
Assignees
Labels
Low Low Priority Issues (to be fixed or re-evaluated in 12 months

Comments

@f0uriest
Copy link

We use codecov-action inside another action that tries in several times in a loop (to prevent failing CI due to intermittent connection issues with the upload).

This seems to be failing after we upgraded to v5 with the message

Error: Runner "composite" does not implemented.

Logs: https://github.com/PlasmaControl/DESC/actions/runs/12259667401/job/34202389650

@thomasrockhu-codecov
Copy link
Contributor

thomasrockhu-codecov commented Dec 12, 2024

@f0uriest this is a problem with Wandalen/wretry.action, its implementation only work on JS actions. its implementation doesn't work on composite actions

Actually, can you bump to the latest of Wandalan/wretry.action?

@thomasrockhu-codecov thomasrockhu-codecov self-assigned this Dec 12, 2024
@thomasrockhu-codecov thomasrockhu-codecov added the Low Low Priority Issues (to be fixed or re-evaluated in 12 months label Dec 12, 2024
@f0uriest
Copy link
Author

I tried a few different version of Wandalan/wretry.action and none seemed to work. For now we've gotten rid of the retry and seems to be ok.

Given that v5 of codecov-action just wraps the CLI, and the CLI itself has options for retrying, would it be possible to plumb that option out?

@thomasrockhu-codecov
Copy link
Contributor

@f0uriest maybe I'm missing something, but I'm fairly sure the CLI does not have retry options exposed. If you see that, do you mind pointing it out?

@thomasrockhu-codecov
Copy link
Contributor

@f0uriest going to close this out now, let me know if the problem persists

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Low Low Priority Issues (to be fixed or re-evaluated in 12 months
Projects
None yet
Development

No branches or pull requests

2 participants