Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow analysis of commit messages #45

Open
aspiers opened this issue Dec 12, 2016 · 4 comments
Open

allow analysis of commit messages #45

aspiers opened this issue Dec 12, 2016 · 4 comments

Comments

@aspiers
Copy link

aspiers commented Dec 12, 2016

This spec only seems to provide any mechanism for engines analysing source files, not commit messages. Is that right, and if so, please could it be extended to allow analysis of commit messages? There are already tools such as Gitlint and m1foley/fit-commit which do this analysis client-side, and it would be obviously beneficial to be able to enforce the quality imposed by such audits.

@aspiers
Copy link
Author

aspiers commented Dec 13, 2016

I guess it's easier to simply install gitlint and/or fit-commit in the server-side CI environment and run them as part of the tests:

So maybe this feature request could be ignored, but I'll leave it open for now in case anyone else has any thoughts.

@wfleming
Copy link
Contributor

Hi @aspiers,

Thanks for the feedback. Supporting issues on things other than files is something we've discussed internally, and in fact analyzing commit messages is the use case we've most often discussed as well. So this is certainly something we're interested in supporting.

We do not currently know when we might schedule the work necessary to support this, but knowing what features customers would find useful is always helpful for deciding what to work on, so thanks for opening this: we'll keep this issue open as a potential enhancement.

@dblandin
Copy link
Contributor

Hey @aspiers,

You should definitely check out http://danger.systems / https://github.com/danger/danger by our friends at @artsy. It has a bunch of cool features including support for commit message analysis.

@aspiers
Copy link
Author

aspiers commented Jan 31, 2017

@dblandin Looks great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants