Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve register_check function #109

Open
angelina-momin opened this issue Sep 19, 2024 · 2 comments
Open

Improve register_check function #109

angelina-momin opened this issue Sep 19, 2024 · 2 comments

Comments

@angelina-momin
Copy link
Collaborator

In validate_codecheck_yml function the following should fail the validations:

  1. The field "paper/ reference" in codecheck.yml contains extra text besides the link
  2. The field "report" in codecheck.yml should be an actual link.
  3. The field "ORCID ID" should only contain numbers and should be valid (there exists an ORCID page matching this ID and the author name)
  4. The field "repository link" should be a valid URL
@angelina-momin
Copy link
Collaborator Author

@nuest feel free to add more points if I am missing anything

@nuest
Copy link
Member

nuest commented Sep 20, 2024

I can double check with the current specification what else we can check.

More of a question, because I might have badly phrased my intentions regarding the reference field: The current implementation fails if there is text in the field?

My idea was to have it check if it is a URL, then link, and if not, then there is no link but it does not fail. I think we want a bit flexibility here, to handle papers during review, for example, where we still want them to be present in the register but a DOI does not exist yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants