Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: highlight the interacting elements #3672

Merged
merged 2 commits into from
Jun 4, 2023

Conversation

kobenguyent
Copy link
Collaborator

@kobenguyent kobenguyent commented May 30, 2023

Motivation/Description of the PR

Applicable helpers:

  • Puppeteer
  • Playwright
  • Webdriver

Type of change

  • 🚀 New functionality

Checklist:

  • Documentation has been added (Run npm run docs)
  • Lint checking (Run npm run lint)
  • Local tests are passed (Run npm test)

@DavertMik
Copy link
Contributor

Wow!

Copy link
Contributor

@DavertMik DavertMik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So simple yet awesome!
I would somehow turn that on if I run tests with --debug flag,
Can we also have it for WebDriver?

Copy link
Contributor

@DavertMik DavertMik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So simple yet awesome!
I would somehow turn that on if I run tests with --debug flag,
Can we also have it for WebDriver?

@DavertMik
Copy link
Contributor

@kobenguyent please fix Puppeteer tests

@DavertMik
Copy link
Contributor

@kobenguyent I think that would be essential thing for writing tests with AI
as you will see all options while writing it

@kobenguyent
Copy link
Collaborator Author

So simple yet awesome! I would somehow turn that on if I run tests with --debug flag, Can we also have it for WebDriver?

Webdriver support is added. I'm not sure how to acknowledge is the --debug is passed. May you advise on that?

@kobenguyent please fix Puppeteer tests

Oh, fixed it.

@EgorBodnar
Copy link
Contributor

🔥🔥

@DavertMik
Copy link
Contributor

Seems good to me. Let's have it!

@DavertMik DavertMik merged commit 51556a7 into 3.x Jun 4, 2023
@DavertMik DavertMik deleted the feat/highlight-interacting-fields branch June 4, 2023 10:40
@incoming-th
Copy link

@kobenguyent Thanks a lot, pretty sure next someone will ask to customize the border width and the color :D

@incoming-th
Copy link

@kobenguyent Quick note, this seems to not be working with --debug but with --verbose for helper puppeteer.

Also, it is not showing when using npx codeceptjs run-workers even if highlightElement is true, or I am doing something wrong.

@kobenguyent
Copy link
Collaborator Author

@kobenguyent Quick note, this seems to not be working with --debug but with --verbose for helper puppeteer.

Also, it is not showing when using npx codeceptjs run-workers even if highlightElement is true, or I am doing something wrong.

Hi, please check this #3896

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to highlight fields
5 participants