Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tests are loaded from node_modules folder #3623

Merged
merged 3 commits into from
May 28, 2023
Merged

Conversation

kobenguyent
Copy link
Collaborator

@kobenguyent kobenguyent commented Mar 21, 2023

Motivation/Description of the PR

  • fix the case where tests are loaded from node_modules folder

we have this glob in configuration: tests: './**/*.test.ts',, when tests run, CodeceptJS will load tests in every folder, even the node_modules folder with test.ts files.

Type of change

  • 🐛 Bug fix

Checklist:

  • Tests have been added
  • Documentation has been added (Run npm run docs)
  • Lint checking (Run npm run lint)
  • Local tests are passed (Run npm test)

Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DavertMik DavertMik merged commit 11109b6 into 3.x May 28, 2023
@DavertMik
Copy link
Contributor

Thank you!
Sorry for the delay in review

@DavertMik DavertMik deleted the fix-codeceptjs-test-glob branch May 28, 2023 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants