Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: appium v2 support #3622

Merged
merged 13 commits into from
May 28, 2023
Merged

feat: appium v2 support #3622

merged 13 commits into from
May 28, 2023

Conversation

kobenguyent
Copy link
Collaborator

@kobenguyent kobenguyent commented Mar 21, 2023

Motivation/Description of the PR

Applicable helpers:

  • Appium

Type of change

  • 🔥 Breaking changes

Checklist:

  • Tests have been added
  • Documentation has been added (Run npm run docs)
  • Lint checking (Run npm run lint)
  • Local tests are passed (Run npm test)

Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChetanChohan7
Copy link

@kobenguyent I was taking a look at this as it's of interest to my current work. I noticed in the appium helper file there are several instances where "browser" is misspelt as, "broswer". See lines 192 and 197 in /helper/appium.js

@kobenguyent kobenguyent mentioned this pull request Apr 24, 2023
33 tasks
kobenguyent and others added 3 commits May 8, 2023 07:41
fix [1] Error | TypeError: Cannot read properties of undefined (reading 'restart')
@xuanmai-agilityio
Copy link

@kobenguyent I also found another issue with the _startBrowser function, when Appium runs the 2nd test case, it will run this function and will convert the existing options to add one more appium: prefix in the config.
So I think we need to check and only convert it one time when the Appium starts.
So I've updated it as below and it runs smoothly. Hope this help!

Screen Shot 2023-05-09 at 10 49 59

@kobenguyent
Copy link
Collaborator Author

@kobenguyent I also found another issue with the _startBrowser function, when Appium runs the 2nd test case, it will run this function and will convert the existing options to add one more appium: prefix in the config. So I think we need to check and only convert it one time when the Appium starts. So I've updated it as below and it runs smoothly. Hope this help!

Screen Shot 2023-05-09 at 10 49 59

Thanks @xuanmai-agilityio, issue has been addressed!

@DavertMik
Copy link
Contributor

Thank you, @kobenguyent
I think we are ready to merge this one.
Sorry for the delay in reviewing it

@DavertMik DavertMik merged commit 4aa8450 into 3.x May 28, 2023
@DavertMik DavertMik deleted the appium-v2 branch May 28, 2023 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants