Commit 7c39333
committed
[Fizz] Always load the external runtime if one is provided (facebook#33091)
Because we now decided whether to outline in the flushing phase, when
we're writing the preamble we don't yet know if we will make that
decision so we don't know if it's safe to omit the external runtime.
However, if you are providing an external runtime it's probably a pretty
safe bet you're streaming something dynamically that's likely to need it
so we can always include it.
The main thing is that this makes it hard to test it because it affects
our tests in ways it wouldn't otherwise so we have to add a bunch of
conditions.
DiffTrain build for [f739642](facebook@f739642)1 parent 4d78e93 commit 7c39333
File tree
37 files changed
+838
-458
lines changed- compiled/facebook-www
37 files changed
+838
-458
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1538 | 1538 | | |
1539 | 1539 | | |
1540 | 1540 | | |
1541 | | - | |
| 1541 | + | |
1542 | 1542 | | |
1543 | 1543 | | |
1544 | 1544 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1538 | 1538 | | |
1539 | 1539 | | |
1540 | 1540 | | |
1541 | | - | |
| 1541 | + | |
1542 | 1542 | | |
1543 | 1543 | | |
1544 | 1544 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
636 | 636 | | |
637 | 637 | | |
638 | 638 | | |
639 | | - | |
| 639 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
636 | 636 | | |
637 | 637 | | |
638 | 638 | | |
639 | | - | |
| 639 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
640 | 640 | | |
641 | 641 | | |
642 | 642 | | |
643 | | - | |
| 643 | + | |
644 | 644 | | |
645 | 645 | | |
646 | 646 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
640 | 640 | | |
641 | 641 | | |
642 | 642 | | |
643 | | - | |
| 643 | + | |
644 | 644 | | |
645 | 645 | | |
646 | 646 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
19014 | 19014 | | |
19015 | 19015 | | |
19016 | 19016 | | |
19017 | | - | |
| 19017 | + | |
19018 | 19018 | | |
19019 | 19019 | | |
19020 | | - | |
| 19020 | + | |
19021 | 19021 | | |
19022 | 19022 | | |
19023 | 19023 | | |
| |||
19051 | 19051 | | |
19052 | 19052 | | |
19053 | 19053 | | |
19054 | | - | |
| 19054 | + | |
19055 | 19055 | | |
19056 | 19056 | | |
19057 | 19057 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18786 | 18786 | | |
18787 | 18787 | | |
18788 | 18788 | | |
18789 | | - | |
| 18789 | + | |
18790 | 18790 | | |
18791 | 18791 | | |
18792 | | - | |
| 18792 | + | |
18793 | 18793 | | |
18794 | 18794 | | |
18795 | 18795 | | |
| |||
18823 | 18823 | | |
18824 | 18824 | | |
18825 | 18825 | | |
18826 | | - | |
| 18826 | + | |
18827 | 18827 | | |
18828 | 18828 | | |
18829 | 18829 | | |
| |||
0 commit comments