Skip to content

Commit 0af4fd8

Browse files
authored
[test] Update ESLint e2e tests (facebook#35233)
1 parent 1721e73 commit 0af4fd8

File tree

4 files changed

+10
-8
lines changed

4 files changed

+10
-8
lines changed

fixtures/eslint-v6/index.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -159,9 +159,9 @@ function InvalidGlobals() {
159159
return <div>Done</div>;
160160
}
161161

162-
// Invalid: useMemo with wrong deps - triggers preserve-manual-memoization
162+
// Invalid: useMemo with wrong deps
163163
function InvalidUseMemo({items}) {
164-
// eslint-disable-next-line react-hooks/preserve-manual-memoization, react-hooks/exhaustive-deps
164+
// eslint-disable-next-line react-hooks/exhaustive-deps
165165
const sorted = useMemo(() => [...items].sort(), []);
166166
return <div>{sorted.length}</div>;
167167
}

fixtures/eslint-v7/index.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -159,9 +159,9 @@ function InvalidGlobals() {
159159
return <div>Done</div>;
160160
}
161161

162-
// Invalid: useMemo with wrong deps - triggers preserve-manual-memoization
162+
// Invalid: useMemo with wrong deps
163163
function InvalidUseMemo({items}) {
164-
// eslint-disable-next-line react-hooks/preserve-manual-memoization, react-hooks/exhaustive-deps
164+
// eslint-disable-next-line react-hooks/exhaustive-deps
165165
const sorted = useMemo(() => [...items].sort(), []);
166166
return <div>{sorted.length}</div>;
167167
}

fixtures/eslint-v8/index.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -159,9 +159,9 @@ function InvalidGlobals() {
159159
return <div>Done</div>;
160160
}
161161

162-
// Invalid: useMemo with wrong deps - triggers preserve-manual-memoization
162+
// Invalid: useMemo with wrong deps
163163
function InvalidUseMemo({items}) {
164-
// eslint-disable-next-line react-hooks/preserve-manual-memoization, react-hooks/exhaustive-deps
164+
// eslint-disable-next-line react-hooks/exhaustive-deps
165165
const sorted = useMemo(() => [...items].sort(), []);
166166
return <div>{sorted.length}</div>;
167167
}

fixtures/eslint-v9/index.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,7 @@ function ComponentWithoutDeclaringPropAsDep(props) {
7070
console.log(props.foo);
7171
// eslint-disable-next-line react-hooks/exhaustive-deps
7272
}, []);
73+
// eslint-disable-next-line react-hooks/void-use-memo
7374
useMemo(() => {
7475
console.log(props.foo);
7576
// eslint-disable-next-line react-hooks/exhaustive-deps
@@ -82,6 +83,7 @@ function ComponentWithoutDeclaringPropAsDep(props) {
8283
console.log(props.foo);
8384
// eslint-disable-next-line react-hooks/exhaustive-deps
8485
}, []);
86+
// eslint-disable-next-line react-hooks/void-use-memo
8587
React.useMemo(() => {
8688
console.log(props.foo);
8789
// eslint-disable-next-line react-hooks/exhaustive-deps
@@ -159,9 +161,9 @@ function InvalidGlobals() {
159161
return <div>Done</div>;
160162
}
161163

162-
// Invalid: useMemo with wrong deps - triggers preserve-manual-memoization
164+
// Invalid: useMemo with wrong deps
163165
function InvalidUseMemo({items}) {
164-
// eslint-disable-next-line react-hooks/preserve-manual-memoization, react-hooks/exhaustive-deps
166+
// eslint-disable-next-line react-hooks/exhaustive-deps
165167
const sorted = useMemo(() => [...items].sort(), []);
166168
return <div>{sorted.length}</div>;
167169
}

0 commit comments

Comments
 (0)