-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
<br /> Breaks the order of biscuits #22
Comments
This is an interesting bug. I will have to look into it. |
Thanks. I did some digging and was able to reproduce that exact bug in an HTML file, but not jsx. Could you provide some more details? What was the file name/extension? In the meantime, here is the branch that fixed my reproduction: https://github.com/code-biscuits/nvim-biscuits/tree/feature-html-only-decorate-elements Feel free to pull it down and try it out. I will be making a PR. Feel free to comment here or there. |
Its a .js file called Sequence2.js that uses react. What kind of other details can I provide ? (Since it s a work file, i cant really share the whole thing). I could if that would help try to reproduce by creating another file if that helps ? Tried the branch you mentionned by doing: |
Ok thanks. Yeah the fixes I did are only for HTML files at the moment. I will dig into trying to reproduce it in my local code, but if you end up creating an example file that is not work-related, let me know. |
Try pulling down from that same branch again. Was able to get it fixed in js, jsx, and html files for that same reproduction. Note: jsx inside class components seems to not work still. Not sure why, but they are seen as strings node types. |
I did try and it seem to have fixed the issue for me, br doesn t affect the p.p1 anymore ! Thank you so much ! |
No worries thanks for the report. I will get that merged into the main branch soon. |
I have this while working on a react file, the biscuit returns the end of p.p1 while it s just the end of the
<br />
any hints on how i could fix this please ?
The text was updated successfully, but these errors were encountered: