Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQUEST] Document "don't care" option for mlx_set_window_limit #109

Closed
Oktosha opened this issue May 25, 2023 · 1 comment
Closed

[REQUEST] Document "don't care" option for mlx_set_window_limit #109

Oktosha opened this issue May 25, 2023 · 1 comment
Labels
Request New feature or request

Comments

@Oktosha
Copy link

Oktosha commented May 25, 2023

Is your feature request related to a problem? Please describe.
I want to limit the minimum size of the window in my so_long, but not the maximum size

Describe the solution you'd like
I want mlx_set_window_limit have documented special values for limits I don't care about

Describe alternatives you've considered
At the moment I do

mlx_set_window_limit(mlx, min_w, min_h, -1, -1);

It works because -1 is the value of GLFW_DONT_CARE and mlx_set_window_limit just passes it to glfwSetWindowSizeLimits.

Additional context
I think that explicit MLX_DONT_CARE constant would be better than passing reverse-engineered -1.

@W2Wizard W2Wizard added the Request New feature or request label May 25, 2023
@W2Wizard
Copy link
Collaborator

Resolved by just documenting this instead. Don't feel like adding a define for this as I have no use for it anywhere else on first glance.

If I have a use for it somewhere else as well I will consider adding the define over just resolving this by adding some docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Request New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants