Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make clippy fails with latest changes #521

Open
tylerfanelli opened this issue Nov 20, 2024 · 1 comment
Open

make clippy fails with latest changes #521

tylerfanelli opened this issue Nov 20, 2024 · 1 comment

Comments

@tylerfanelli
Copy link

It seems that cargo clippy on the kernel module fails now due to the packit dependency. Curious, as there is an
--exclude packit line in make clippy, but I assume this does not apply to clippy applied to the kernel module.

$ make clippy
cargo clippy --workspace --all-features --exclude packit --exclude svsm-fuzz --exclude igvmbuilder --exclude igvmmeasure -- -D warnings
error: failed to load manifest for workspace member `svsm/svsm/kernel`
referenced by workspace at `svsm/svsm/Cargo.toml`

Caused by:
  failed to load manifest for dependency `packit`

Caused by:
  failed to read `svsm/svsm/packit/Cargo.toml`

Caused by:
  No such file or directory (os error 2)
make: *** [Makefile:178: clippy] Error 101
@stefano-garzarella
Copy link
Contributor

Yesterday we merged 2 PRs that changed couple of submodules (packit was part of it), so I guess that could be the issue.
See https://mail.8bytes.org/pipermail/svsm-devel/2024-November/000406.html

So when updating to latest HEAD please make sure to update your
submodules as documented in PR #514:

	# clean all generated files to avoid having folders with left-overs
	git clean -xfd
	git submodule foreach --recursive git clean -xfd

	# sync urls and update/init git submodules
	git submodule sync
	git submodule update --init

The libmstpm/ directory might remain after this and can be safely
deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants