forked from futuretap/InAppSettingsKit
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/merge upstream #5
Open
JensDee
wants to merge
71
commits into
master
Choose a base branch
from
feature/merge-upstream
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raised deployment target to iOS 10.0; declare Catalyst support for SPM;
Cells now default to natural rather than left alignment. Buttons show disclosure indicator if natural or left text alignment is used. thanks @junjie
... at least the travis logs show that. Also - no Xcode 14.3.1 yet? o_O
the workspace itself has been moved to SPM
looks like this broke when the workspace dropped the xcodeproj?
let's stay with one place for running the tests, via SPM
the test action in the xcodeproject isn't supported
TARGET_OS_XR has been renamed to TARGET_OS_VISION
…read the plist files from
Add `bundle` property
minor updates to README and RELEASE_NOTES
fix bundle for child panes
when `IASKCellImage` is set, check if an image with that name is present, then fallback to `-systemImageNamed:` aka SF Symbols fixes futuretap#459
when set to true for a PSMultiValueSpecifier, the child view controller is popped on selection
Use tintColor for editable content such as the value in `PSMultiValueSpecifier` or `PSChildPaneSpecifier`. Exception: MultiValue elements in list groups are not tinted to emphasize the "Add" button.
indicating that the validation is OK with the replacement performed; this is useful to auto-fix wrong content (the sample app adds an @ as the account name prefix);
Support localizable `File` for `IASKAppSettingsWebViewController`
…nexpected opening of Safari See: futuretap#512
IASKColorSchemeSystem: color scheme replicating the system settings IASKColorSchemeTinted: color scheme where user-editable options are displayed in tintColor fixes futuretap#513
Always allow Navigation Action for http/https URL scheme to prevent u…
Allow loading of files in IASKAppSettingsWebViewController
This will prevent a crash. See: futuretap#515 (comment)
Because the observer for `estimatedProgress` has already been fired before and set a value > 0.0 to the progress bar This bug was discovered during implementation of futuretap#515
# Conflicts: # InAppSettingsKit.xcodeproj/project.pbxproj # InAppSettingsKit.xcodeproj/xcshareddata/xcschemes/InAppSettingsKit.xcscheme # InAppSettingsKit.xcworkspace/xcshareddata/xcschemes/InAppSettingsKit.xcscheme # Sources/InAppSettingsKit/Controllers/IASKSpecifierValuesViewController.m
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.