sql/schemachanger/rel,scplan/rules: add support for rules, _; adopt #82569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This change is |
rel rules are sort of like macros which can expand variable usages to eliminate logic duplication. They are defined per-schema. This cleans up rules defintions quite nicely. The _ rel.Var (aka rel.Blank) is used to indicate that a binding must occur but that its value is not to be saved. Note that Blank cannot be used as an entity in a query. This limitation could be lifted in the future. Release note: None
This commit introduces nodeVars to help write rules in a cleaner way. It associates the variable triples for element, target, and node together in a structure. Release note: None
postamar
approved these changes
Jun 9, 2022
postamar
left a comment
postamar
left a comment
There was a problem hiding this comment.
Reviewed 26 of 26 files at r1, 8 of 8 files at r2, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @ajwerner)
pkg/sql/schemachanger/rel/schema_rules.go line 46 at r1 (raw file):
type Rule3 = func(a, b, c Var) Clause // Rule4 is a rule with three input variables.
nit: s/three/four
Contributor
Author
|
bors r+ @postamar or I will fix the comment in a separate PR. |
Contributor
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit extends the
rellanguage with support for rules and_and adopts it for the dep rules. The second commit contains further cleanup and adopts in op rules.Release note: None