Skip to content

Conversation

@rickystewart
Copy link
Collaborator

@rickystewart rickystewart commented Nov 13, 2025

Backport 1/1 commits from #157769 on behalf of @rickystewart.


See the EngFlow blog post.

Release note: none
Epic: none


Release justification: Non-production code changes

@rickystewart rickystewart requested a review from a team as a code owner November 13, 2025 19:51
@rickystewart rickystewart force-pushed the blathers/backport-release-24.1-157769 branch from 48c891c to b274fcb Compare November 13, 2025 19:51
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Nov 13, 2025
@blathers-crl blathers-crl bot requested a review from rail November 13, 2025 19:51
@blathers-crl
Copy link

blathers-crl bot commented Nov 13, 2025

Thanks for opening a backport.

Before merging, please confirm that it falls into one of the following categories (select one):

  • Non-production code changes. Includes test-only changes, build system changes, etc.
  • Fixes for serious issues. Defined in the policy as correctness, stability, or security issues, data corruption/loss, significant performance regressions, breaking working and widely used functionality, or an inability to detect and debug production issues.
  • Other approved changes. These changes must be gated behind a disabled-by-default feature flag unless there is a strong justification not to.

Add a brief release justification to the PR description explaining your selection.

Also, confirm that the change does not break backward compatibility and complies with all aspects of the backport policy.

All backports must be reviewed by the TL and EM for the owning area.

@blathers-crl blathers-crl bot added backport Label PR's that are backports to older release branches T-code-systems labels Nov 13, 2025
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@blathers-crl
Copy link

blathers-crl bot commented Nov 13, 2025

✅ PR #157779 is compliant with backport policy

Confidence: high
Backward compatible: true
Explanation: The PR is compliant with the CockroachDB backport policy for non-production code changes. The provided PR details include a release justification line explicitly stating that the changes affect 'Non-production code changes'. Additionally, the changed file path 'build/github/engflow-args.sh' falls under the development tools category for build and CI files listed in the non-production file patterns ('teamcity/', 'pkg/build/version.txt', 'REPOSITORIES.bzl'). Since the changes only impact non-production code, they are exempt from the standard backport policy requirements, including the need for critical bug justification or feature flag gating.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@rickystewart rickystewart merged commit 5c725b0 into cockroachdb:release-24.1 Nov 14, 2025
25 of 26 checks passed
@rickystewart rickystewart deleted the blathers/backport-release-24.1-157769 branch November 14, 2025 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. T-code-systems target-release-24.1.26

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants