logictest: fix recently introduced race around allowUnsafe #157773
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just use the atomic since we might have concurrent internal queries reading the current value of the testing knob override. Release note: None
yuzefovich
requested review from
a team,
DrewKimball,
angles-n-daemons and
rafiss
and removed request for
a team
Member
|
This change is |
rafiss
approved these changes
Nov 13, 2025
Collaborator
|
thanks for the fix! |
DrewKimball
approved these changes
Nov 13, 2025
Collaborator
DrewKimball
left a comment
DrewKimball
left a comment
There was a problem hiding this comment.
@DrewKimball reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @angles-n-daemons)
Member
Author
|
TFTRs! bors r+ |
angles-n-daemons
approved these changes
Nov 13, 2025
Contributor
angles-n-daemons
left a comment
angles-n-daemons
left a comment
There was a problem hiding this comment.
thanks for the fix!
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just use the atomic since we might have concurrent internal queries reading the current value of the testing knob override.
Fixes: #157378
Release note: None