kvserver: remove bq.replicaCanBeProcessed right before bq.processReplica #152507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Member
|
This change is |
wenyihu6
force-pushed
the
removereplicacanberepro
branch
2 times, most recently
from
1777d43 to
72773d3
Compare
Previously, we called bq.replicaCanBeProcessed with acquireLeaseIfNeeded = false before invoking bq.processReplica, which itself calls replicaCanBeProcessed with acquireLeaseIfNeeded = true. This looks incorrect and did not exist prior to cockroachdb@c9cf068. It’s unclear how often lease renewal is actually going to be helpful here, but I removed these two calls since they were newly introduced and seem unintentional. Informs: cockroachdb#151292 Release note: none
wenyihu6
force-pushed
the
removereplicacanberepro
branch
from
72773d3 to
adb3040
Compare
wenyihu6
changed the title
tbg
approved these changes
Aug 28, 2025
Member
tbg
left a comment
tbg
left a comment
There was a problem hiding this comment.
Good catch!
@tbg reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @arulajmani and @pav-kv)
Contributor
Author
|
TFTR! bors r=tbg |
Contributor
This was referenced Sep 5, 2025
celeste-cockroachdb
bot
added
v25.4.0-prerelease
and removed
target-release-25.4.0
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we called bq.replicaCanBeProcessed with acquireLeaseIfNeeded = false
before invoking bq.processReplica, which itself calls replicaCanBeProcessed with
acquireLeaseIfNeeded = true. This looks incorrect and did not exist prior to
c9cf068. It’s unclear how often lease renewal is actually going to be helpful
here, but I removed these two calls since they were newly introduced and seem
unintentional.
Informs: #151292
Release note: none