Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace http-addr flag with http-host for consistency #9516

Closed
a-robinson opened this issue Sep 23, 2016 · 3 comments
Closed

Replace http-addr flag with http-host for consistency #9516

a-robinson opened this issue Sep 23, 2016 · 3 comments
Assignees

Comments

@a-robinson
Copy link
Contributor

Correct me if I'm wrong, but I'd guess we don't want to remove http-addr at the same time that we add http-host, since it'll annoy people and make our docs incorrect for at least some small time period.

I assume it's good enough to add the new flag with precedence over the old one, wait for a new beta release, then update the docs and remove the old one?

As discussed in #9503

@mberhault @sploiselle

@a-robinson a-robinson self-assigned this Sep 23, 2016
@tamird
Copy link
Contributor

tamird commented Sep 23, 2016

It may also be the case that nobody is using http-addr in practice, which would make this simpler.

@sploiselle
Copy link
Contributor

In favor of that plan, @a-robinson. Always prefer gentle deprecation even if it's not much more than a gesture of general good will. Switching it in the docs, assuming it exactly duplicates the functionality, is simple.

Can we include an error message for http-addr that just spits back that it's now http-host? If it's more than nominal effort, think we can get by without it.

@a-robinson
Copy link
Contributor Author

Adding Sean to get the docs updated with the http-host flag. Once they're updated and a new release has been cut, I'll remove http-addr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants