-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
server, ui: Merge Admin and Status endpoints #24989
Labels
A-kv-server
Relating to the KV-level RPC server
A-server-architecture
Relates to the internal APIs and src org for server code
A-webui-general
Issues on the DB Console that span multiple areas or don't have another clear category.
C-cleanup
Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior.
Comments
Assigning this to @couchand for triage. |
knz
added
C-cleanup
Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior.
and removed
refactoring
labels
Apr 24, 2018
couchand
changed the title
ui: Merge Admin and Status endpoints
server, ui: Merge Admin and Status endpoints
Apr 24, 2018
couchand
added
the
A-webui-general
Issues on the DB Console that span multiple areas or don't have another clear category.
label
Apr 24, 2018
My proposal, in light of the login work, is that status house endpoints that are accessible anonymously, and admin the endpoints that are not. (see #25526) |
We will not get to this in 2.1, bumping to Later. We can pull it into 2.2 depending on other priorities. |
cc @thtruo @piyush-singh for tracking. This becomes highly relevant with our new transition to API-first |
knz
added
the
A-server-architecture
Relates to the internal APIs and src org for server code
label
Jul 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-kv-server
Relating to the KV-level RPC server
A-server-architecture
Relates to the internal APIs and src org for server code
A-webui-general
Issues on the DB Console that span multiple areas or don't have another clear category.
C-cleanup
Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior.
We have, for historical reasons, two different main endpoints for UI and Status data.
Originally, as we were upgrading the UI, the admin endpoint was supposed to handle all requests that were destined for the admin ui, as opposed to other misc endpoints. But that distinction is no longer true and never really was.
We also have to make sure that permissions are clear for every endpoint. And having the two endpoints is clearly just complicating that.
For anyone looking to add a new endpoint, there is no clear guidance, this makes doing any admin ui work more complicated.
I started auditing both and here are the endpoints in both right now:
Admin
Status:
It's obvious that there is no clear division between the two endpoints and I recommend that we move all into Status, just because there is less code movement. We should of course maintain the old links, at least until v2.2 or even v3.0.
Jira issue: CRDB-5737
The text was updated successfully, but these errors were encountered: