From e847f560655c05462ab2b0b12d2e9470b2f1dcea Mon Sep 17 00:00:00 2001 From: Jackson Owens Date: Mon, 20 Mar 2023 17:58:02 +0000 Subject: [PATCH] roachtest: set 30m timeout for all disk stall roachtests This commit sets a new 30m timeout for all disk stall roachtests. Previously, the FUSE filesystem variants had no timeout and inherited the default 10h timeout. The other variants had a 20m timeout, which has been observed to be too short due to upreplication latency. Informs #98904. Informs #98886. Epic: None Release note: None --- pkg/cmd/roachtest/tests/disk_stall.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/pkg/cmd/roachtest/tests/disk_stall.go b/pkg/cmd/roachtest/tests/disk_stall.go index 89fd18058ff4..a3349fdc0cb7 100644 --- a/pkg/cmd/roachtest/tests/disk_stall.go +++ b/pkg/cmd/roachtest/tests/disk_stall.go @@ -51,7 +51,7 @@ func registerDiskStalledDetection(r registry.Registry) { Name: fmt.Sprintf("disk-stalled/%s", name), Owner: registry.OwnerStorage, Cluster: r.MakeClusterSpec(4, spec.ReuseNone()), - Timeout: 20 * time.Minute, + Timeout: 30 * time.Minute, Run: func(ctx context.Context, t test.Test, c cluster.Cluster) { runDiskStalledDetection(ctx, t, c, makeStaller(t, c), true /* doStall */) }, @@ -77,6 +77,7 @@ func registerDiskStalledDetection(r registry.Registry) { ), Owner: registry.OwnerStorage, Cluster: r.MakeClusterSpec(4, spec.ReuseNone()), + Timeout: 30 * time.Minute, Run: func(ctx context.Context, t test.Test, c cluster.Cluster) { runDiskStalledDetection(ctx, t, c, &fuseDiskStaller{ t: t,