Merge pull request #115025 from cockroachdb/blathers/backport-release-23.2-114773

release-23.2: storage: avoid expensive logging in MVCCAcquireLock

Author: nvb

pkg/storage/mvcc.go

@@ -5938,9 +5938,11 @@ func MVCCAcquireLock(
 			// number, our newer sequence number could then be rolled back and
 			// we would forget that the lock held at the older sequence number
 			// had been and still should be held.
-			log.VEventf(ctx, 3, "skipping lock acquisition for txn %s on key %s "+
-				"with strength %s; found existing lock with strength %s and sequence %d",
-				txn, key.String(), str.String(), iterStr.String(), foundLock.Txn.Sequence)
+			if log.ExpensiveLogEnabled(ctx, 3) {
+				log.VEventf(ctx, 3, "skipping lock acquisition for txn %s on key %s "+
+					"with strength %s; found existing lock with strength %s and sequence %d",
+					txn, key, str, iterStr, foundLock.Txn.Sequence)
+			}
 			return nil
 		}